You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Jasvir Nagra (JIRA)" <ji...@apache.org> on 2008/08/11 03:39:44 UTC

[jira] Created: (SHINDIG-508) Failed tests prevent mvn package and install

Failed tests prevent mvn package and install
--------------------------------------------

                 Key: SHINDIG-508
                 URL: https://issues.apache.org/jira/browse/SHINDIG-508
             Project: Shindig
          Issue Type: Bug
          Components: Common Components (Java)
            Reporter: Jasvir Nagra


A pristine checkout of shindig HEAD has three broken tests because of inconsistent use of case for the key "displayValue" in canonical.json.

Results :

Tests in error:
  testGetPersonAllFields(org.apache.shindig.social.sample.spi.JsonDbOpensocialServiceTest)
  testGetExpectedFriends(org.apache.shindig.social.sample.spi.JsonDbOpensocialServiceTest)
  testGetPersonJson(org.apache.shindig.social.dataservice.integration.RestfulJsonPeopleTest)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-508) Failed tests prevent mvn package and install

Posted by "Jasvir Nagra (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jasvir Nagra updated SHINDIG-508:
---------------------------------

    Attachment: fix-broken-build-displayvalue.patch

Changes java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Enum.java and javascript/sampledata/canonicaldb.json to make consistent all uses of displayValue.

> Failed tests prevent mvn package and install
> --------------------------------------------
>
>                 Key: SHINDIG-508
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-508
>             Project: Shindig
>          Issue Type: Bug
>          Components: Common Components (Java)
>            Reporter: Jasvir Nagra
>         Attachments: fix-broken-build-displayvalue.patch
>
>
> A pristine checkout of shindig HEAD has three broken tests because of inconsistent use of case for the key "displayValue" in canonical.json.
> Results :
> Tests in error:
>   testGetPersonAllFields(org.apache.shindig.social.sample.spi.JsonDbOpensocialServiceTest)
>   testGetExpectedFriends(org.apache.shindig.social.sample.spi.JsonDbOpensocialServiceTest)
>   testGetPersonJson(org.apache.shindig.social.dataservice.integration.RestfulJsonPeopleTest)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: [jira] Updated: (SHINDIG-508) Failed tests prevent mvn package and install

Posted by Louis Ryan <lr...@google.com>.
Fixed Java side and committed. It should have been displayValue all
along....

On Mon, Aug 11, 2008 at 2:08 AM, Chris Chabot <ch...@xs4all.nl> wrote:

> Woops; Those got in during the php json db work, my apologies!
>
> Cassie, should we apply
> social/opensocial/model/Enum.java:
> -    DISPLAY_VALUE("displayvalue");
> +    DISPLAY_VALUE("displayValue");
>
> or shall we settle for sticking to displayvalue for now?
>
>        -- Chris
>
>
> On Aug 11, 2008, at 4:05 AM, Jasvir Nagra (JIRA) wrote:
>
>
>>    [
>> https://issues.apache.org/jira/browse/SHINDIG-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
>>  ]
>>
>> Jasvir Nagra updated SHINDIG-508:
>> ---------------------------------
>>
>>   Attachment:     (was: fix-broken-build-displayvalue.patch)
>>
>>  Failed tests prevent mvn package and install
>>> --------------------------------------------
>>>
>>>               Key: SHINDIG-508
>>>               URL: https://issues.apache.org/jira/browse/SHINDIG-508
>>>           Project: Shindig
>>>        Issue Type: Bug
>>>        Components: Common Components (Java)
>>>          Reporter: Jasvir Nagra
>>>       Attachments: fix-broken-build-displayvalue.patch
>>>
>>>
>>> A pristine checkout of shindig HEAD has three broken tests because of
>>> inconsistent use of case for the key "displayValue" in canonical.json.
>>> Results :
>>> Tests in error:
>>>
>>>  testGetPersonAllFields(org.apache.shindig.social.sample.spi.JsonDbOpensocialServiceTest)
>>>
>>>  testGetExpectedFriends(org.apache.shindig.social.sample.spi.JsonDbOpensocialServiceTest)
>>>
>>>  testGetPersonJson(org.apache.shindig.social.dataservice.integration.RestfulJsonPeopleTest)
>>>
>>
>> --
>> This message is automatically generated by JIRA.
>> -
>> You can reply to this email to add a comment to the issue online.
>>
>
>

Re: [jira] Updated: (SHINDIG-508) Failed tests prevent mvn package and install

Posted by Chris Chabot <ch...@xs4all.nl>.
Woops; Those got in during the php json db work, my apologies!

Cassie, should we apply
social/opensocial/model/Enum.java:
-    DISPLAY_VALUE("displayvalue");
+    DISPLAY_VALUE("displayValue");

or shall we settle for sticking to displayvalue for now?

	-- Chris

On Aug 11, 2008, at 4:05 AM, Jasvir Nagra (JIRA) wrote:

>
>     [ https://issues.apache.org/jira/browse/SHINDIG-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel 
>  ]
>
> Jasvir Nagra updated SHINDIG-508:
> ---------------------------------
>
>    Attachment:     (was: fix-broken-build-displayvalue.patch)
>
>> Failed tests prevent mvn package and install
>> --------------------------------------------
>>
>>                Key: SHINDIG-508
>>                URL: https://issues.apache.org/jira/browse/SHINDIG-508
>>            Project: Shindig
>>         Issue Type: Bug
>>         Components: Common Components (Java)
>>           Reporter: Jasvir Nagra
>>        Attachments: fix-broken-build-displayvalue.patch
>>
>>
>> A pristine checkout of shindig HEAD has three broken tests because  
>> of inconsistent use of case for the key "displayValue" in  
>> canonical.json.
>> Results :
>> Tests in error:
>>   
>> testGetPersonAllFields 
>> (org.apache.shindig.social.sample.spi.JsonDbOpensocialServiceTest)
>>   
>> testGetExpectedFriends 
>> (org.apache.shindig.social.sample.spi.JsonDbOpensocialServiceTest)
>>   
>> testGetPersonJson 
>> (org 
>> .apache.shindig.social.dataservice.integration.RestfulJsonPeopleTest)
>
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-508) Failed tests prevent mvn package and install

Posted by "Jasvir Nagra (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jasvir Nagra updated SHINDIG-508:
---------------------------------

    Attachment:     (was: fix-broken-build-displayvalue.patch)

> Failed tests prevent mvn package and install
> --------------------------------------------
>
>                 Key: SHINDIG-508
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-508
>             Project: Shindig
>          Issue Type: Bug
>          Components: Common Components (Java)
>            Reporter: Jasvir Nagra
>         Attachments: fix-broken-build-displayvalue.patch
>
>
> A pristine checkout of shindig HEAD has three broken tests because of inconsistent use of case for the key "displayValue" in canonical.json.
> Results :
> Tests in error:
>   testGetPersonAllFields(org.apache.shindig.social.sample.spi.JsonDbOpensocialServiceTest)
>   testGetExpectedFriends(org.apache.shindig.social.sample.spi.JsonDbOpensocialServiceTest)
>   testGetPersonJson(org.apache.shindig.social.dataservice.integration.RestfulJsonPeopleTest)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHINDIG-508) Failed tests prevent mvn package and install

Posted by "Louis Ryan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Louis Ryan resolved SHINDIG-508.
--------------------------------

    Resolution: Fixed
      Assignee: Louis Ryan

Applied patch from Jasvir. Also corrected case error in Enum type in Java

> Failed tests prevent mvn package and install
> --------------------------------------------
>
>                 Key: SHINDIG-508
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-508
>             Project: Shindig
>          Issue Type: Bug
>          Components: Common Components (Java)
>            Reporter: Jasvir Nagra
>            Assignee: Louis Ryan
>         Attachments: fix-broken-build-displayvalue.patch
>
>
> A pristine checkout of shindig HEAD has three broken tests because of inconsistent use of case for the key "displayValue" in canonical.json.
> Results :
> Tests in error:
>   testGetPersonAllFields(org.apache.shindig.social.sample.spi.JsonDbOpensocialServiceTest)
>   testGetExpectedFriends(org.apache.shindig.social.sample.spi.JsonDbOpensocialServiceTest)
>   testGetPersonJson(org.apache.shindig.social.dataservice.integration.RestfulJsonPeopleTest)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-508) Failed tests prevent mvn package and install

Posted by "Jasvir Nagra (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jasvir Nagra updated SHINDIG-508:
---------------------------------

    Attachment: fix-broken-build-displayvalue.patch

Changes java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Enum.java and javascript/sampledata/canonicaldb.json to make consistent all uses of displayValue.

> Failed tests prevent mvn package and install
> --------------------------------------------
>
>                 Key: SHINDIG-508
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-508
>             Project: Shindig
>          Issue Type: Bug
>          Components: Common Components (Java)
>            Reporter: Jasvir Nagra
>         Attachments: fix-broken-build-displayvalue.patch
>
>
> A pristine checkout of shindig HEAD has three broken tests because of inconsistent use of case for the key "displayValue" in canonical.json.
> Results :
> Tests in error:
>   testGetPersonAllFields(org.apache.shindig.social.sample.spi.JsonDbOpensocialServiceTest)
>   testGetExpectedFriends(org.apache.shindig.social.sample.spi.JsonDbOpensocialServiceTest)
>   testGetPersonJson(org.apache.shindig.social.dataservice.integration.RestfulJsonPeopleTest)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.