[trafficserver] branch master updated: Coverity 1379270 Out-of-bounds write

[pa...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

paziz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/master by this push:
     new 01494e0  Coverity 1379270 Out-of-bounds write
01494e0 is described below

commit 01494e0460b09a0142068765c0d3c9bf47addfb1
Author: Persia Aziz <pe...@yahoo-inc.com>
AuthorDate: Fri Aug 11 10:03:40 2017 -0500

    Coverity 1379270 Out-of-bounds write
---
 proxy/Plugin.cc | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/proxy/Plugin.cc b/proxy/Plugin.cc
index 250edf1..587ec4d 100644
--- a/proxy/Plugin.cc
+++ b/proxy/Plugin.cc
@@ -299,8 +299,12 @@ plugin_init(bool validateOnly)
         argv[i] = vars[i];
       }
     }
-    argv[argc] = nullptr;
 
+    if (argc < MAX_PLUGIN_ARGS) {
+      argv[argc] = nullptr;
+    } else {
+      argv[MAX_PLUGIN_ARGS - 1] = nullptr;
+    }
     retVal = plugin_load(argc, argv, validateOnly);
 
     for (i = 0; i < argc; i++) {

-- 
To stop receiving notification emails like this one, please contact
['"commits@trafficserver.apache.org" <co...@trafficserver.apache.org>'].