You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/12 23:20:03 UTC

[GitHub] [kafka] akhileshchg commented on a diff in pull request #12628: KAFKA-14214: Introduce read-write lock to StandardAuthorizer for consistent ACL reads.

akhileshchg commented on code in PR #12628:
URL: https://github.com/apache/kafka/pull/12628#discussion_r969009047


##########
metadata/src/main/java/org/apache/kafka/metadata/authorizer/StandardAuthorizerData.java:
##########
@@ -534,49 +535,19 @@ Iterable<AclBinding> acls(AclBindingFilter filter) {
     }
 
     class AclIterable implements Iterable<AclBinding> {
-        private final AclBindingFilter filter;
+        private final List<AclBinding> aclBindingList;
 
         AclIterable(AclBindingFilter filter) {
-            this.filter = filter;
+            this.aclBindingList = aclsByResource

Review Comment:
   Yes, you're right. I think there is no other way we can guarantee the consistency here other than giving an Iterable that stays constant to the client accessing `Authorizer#acls`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org