[GitHub] [maven] rotty3000 commented on issue #239: MNG-6605 Unable to suppress download messages in interactive mode

[GitBox <gi...@apache.org>]

rotty3000 commented on issue #239: MNG-6605 Unable to suppress download messages in interactive mode
URL: https://github.com/apache/maven/pull/239#issuecomment-478388499
 
 
   Ah ok, I even had ntp but changed it because I thought it might imply
   something about time but I'll change it back.
   
   On Sun, Mar 31, 2019, 17:22 Michael Osipov, <no...@github.com>
   wrote:
   
   > *@michael-o* requested changes on this pull request.
   >
   > Except for those nags, the rest looks fine to me.
   > ------------------------------
   >
   > In maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java
   > <https://github.com/apache/maven/pull/239#discussion_r270685287>:
   >
   > > @@ -101,6 +101,8 @@
   >
   >      public static final String BUILDER = "b";
   >
   > +    public static final String NO_TRANSFER_PROGRESS = "np";
   >
   > This one's to similar to npu, npr and friends. It should be ntp.
   > ------------------------------
   >
   > In maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java
   > <https://github.com/apache/maven/pull/239#discussion_r270685296>:
   >
   > > @@ -140,6 +142,7 @@ public CLIManager()
   >          options.addOption( OptionBuilder.withLongOpt( "threads" ).hasArg().withDescription( "Thread count, for instance 2.0C where C is core multiplied" ).create( THREADS ) );
   >          options.addOption( OptionBuilder.withLongOpt( "legacy-local-repository" ).withDescription( "Use Maven 2 Legacy Local Repository behaviour, ie no use of _remote.repositories. Can also be activated by using -Dmaven.legacyLocalRepo=true" ).create( LEGACY_LOCAL_REPOSITORY ) );
   >          options.addOption( OptionBuilder.withLongOpt( "builder" ).hasArg().withDescription( "The id of the build strategy to use" ).create( BUILDER ) );
   > +        options.addOption( OptionBuilder.withLongOpt( "no-transfer-progress" ).withDescription( "Do not display transfer progress when downloading" ).create( NO_TRANSFER_PROGRESS ) );
   >
   > It is uploading too
   >
   Ah right. Will update later today.
   
   Thanks for the feedback.
   
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/maven/pull/239#pullrequestreview-220884244>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAI9TAQGfkPQU1Eg3KhUGmvIImZVAGduks5vcScfgaJpZM4cPEtt>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services