[GitHub] betodealmeida commented on a change in pull request #5715: [Table view] Handle empty arrays in fd.timeseries_limit_metric

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #5715: [Table view] Handle empty arrays in fd.timeseries_limit_metric
URL: https://github.com/apache/incubator-superset/pull/5715#discussion_r213517260
 
 

 ##########
 File path: superset/assets/src/visualizations/table.js
 ##########
 @@ -185,9 +185,12 @@ function tableVis(slice, payload) {
       container.find('.dataTables_wrapper'), height);
   // Sorting table by main column
   let sortBy;
-  if (fd.timeseries_limit_metric) {
+  const limitMetric = Array.isArray(fd.timeseries_limit_metric)
 
 Review comment:
   Technically no, if the array has no elements then `limitMetric` is `undefined`, which is false and does the expected in line 191.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org