You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "turcsanyip (via GitHub)" <gi...@apache.org> on 2023/06/01 21:06:06 UTC
[GitHub] [nifi] turcsanyip opened a new pull request, #7326: NIFI-11628: Fixed Object[] + Throwable argument substitution in Simpl…
turcsanyip opened a new pull request, #7326:
URL: https://github.com/apache/nifi/pull/7326
…eProcessLogger
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-11628](https://issues.apache.org/jira/browse/NIFI-11628)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7326: NIFI-11628: Fixed Object[] + Throwable argument substitution in Simpl…
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #7326:
URL: https://github.com/apache/nifi/pull/7326#discussion_r1213695849
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/processor/SimpleProcessLogger.java:
##########
@@ -91,7 +91,8 @@ public void warn(final String msg, final Object[] os, final Throwable t) {
logger.warn(componentMessage, arguments);
logRepository.addLogMessage(LogLevel.WARN, componentMessage, arguments);
} else {
- logger.warn(componentMessage, arguments, t);
+ final Object[] argumentsWithThrowable = insertThrowable(arguments, t);
+ logger.warn(componentMessage, setFormattedThrowable(argumentsWithThrowable, t));
Review Comment:
`setFormattedThrowable` adds both `Throwable.toString()` and `Throwable`, which is not generally what should happen. For this to work properly, the formatted component message would also need to change, however, the `Throwable.toString()` should not be part of the log message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #7326: NIFI-11628: Fixed Object[] + Throwable argument substitution in Simpl…
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory closed pull request #7326: NIFI-11628: Fixed Object[] + Throwable argument substitution in Simpl…
URL: https://github.com/apache/nifi/pull/7326
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] turcsanyip commented on a diff in pull request #7326: NIFI-11628: Fixed Object[] + Throwable argument substitution in Simpl…
Posted by "turcsanyip (via GitHub)" <gi...@apache.org>.
turcsanyip commented on code in PR #7326:
URL: https://github.com/apache/nifi/pull/7326#discussion_r1214438375
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/processor/SimpleProcessLogger.java:
##########
@@ -91,7 +91,8 @@ public void warn(final String msg, final Object[] os, final Throwable t) {
logger.warn(componentMessage, arguments);
logRepository.addLogMessage(LogLevel.WARN, componentMessage, arguments);
} else {
- logger.warn(componentMessage, arguments, t);
+ final Object[] argumentsWithThrowable = insertThrowable(arguments, t);
+ logger.warn(componentMessage, setFormattedThrowable(argumentsWithThrowable, t));
Review Comment:
`Throwable.toString()` will not be present in the formatted log message if there is no `{}` placeholder for it (that is all `{}` placeholders are covered by explicit arguments passed in by the caller) so it would not cause an issue.
I think `setFormattedThrowable()` was a convenience addition for log messages ending with `due to {}`. In this case the caller does not need to pass `t.toString()` explicitly but it can be derived from the `Throwable` parameter.
On the other hand, the callers in the current codebase always pass the `Throwable` argument explicitly for the `{}` substitution too and therefore we can omit the `setFormattedThrowable()` call.
The main point of this PR to fix the regular arguments and not to focus on the Throwable / `due to {}` clause so I will remove `setFormattedThrowable()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org