Re: [PR] feat(kvrocks2redis): support HFE in full export and migration WAL [kvrocks]

["PragmaTwice (via GitHub)" <gi...@apache.org>]

PragmaTwice commented on code in PR #3644:
URL: https://github.com/apache/kvrocks/pull/3644#discussion_r4104490476


##########
CMakeLists.txt:
##########
@@ -319,6 +319,7 @@ target_link_libraries(kvrocks2redis PRIVATE kvrocks_objs ${EXTERNAL_LIBS})
 # kvrocks unit tests
 file(GLOB_RECURSE TESTS_SRCS tests/cppunit/*.cc)
 add_executable(unittest ${TESTS_SRCS})
-target_include_directories(unittest PRIVATE tests/cppunit)
+target_sources(unittest PRIVATE utils/kvrocks2redis/parser.cc utils/kvrocks2redis/writer.cc)
+target_include_directories(unittest PRIVATE tests/cppunit ${PROJECT_SOURCE_DIR})

Review Comment:
   include `./utils` instead of `./`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org