Re: [I] `var(distinct)` support [datafusion]

["Jefffrey (via GitHub)" <gi...@apache.org>]

Jefffrey commented on issue #2410:
URL: https://github.com/apache/datafusion/issues/2410#issuecomment-3637212093

   Checklist of things needed to be implemented. For reference existing implementation:
   
   https://github.com/apache/datafusion/blob/2a08013af3ccf703bee202c959b40bb0d35bdea1/datafusion/functions-aggregate/src/variance.rs
   
   Distinct accumulator for variance, see example for median:
   
   https://github.com/apache/datafusion/blob/2a08013af3ccf703bee202c959b40bb0d35bdea1/datafusion/functions-aggregate/src/median.rs#L511-L542
   
   Make sure to wire distinct accumulator into the UDAF:
   
   https://github.com/apache/datafusion/blob/2a08013af3ccf703bee202c959b40bb0d35bdea1/datafusion/functions-aggregate/src/median.rs#L151-L184
   
   https://github.com/apache/datafusion/blob/2a08013af3ccf703bee202c959b40bb0d35bdea1/datafusion/functions-aggregate/src/median.rs#L132-L149
   
   Add tests here:
   
   https://github.com/apache/datafusion/blob/2a08013af3ccf703bee202c959b40bb0d35bdea1/datafusion/sqllogictest/test_files/aggregate.slt


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org