[GitHub] [spark] rangadi commented on a diff in pull request #38384: [SPARK-40657][PROTOBUF] Require shading for Java class jar, improve error handling

["rangadi (via GitHub)" <gi...@apache.org>]

rangadi commented on code in PR #38384:
URL: https://github.com/apache/spark/pull/38384#discussion_r1163659080


##########
connector/protobuf/pom.xml:
##########
@@ -93,6 +93,7 @@
         <artifactId>maven-shade-plugin</artifactId>
         <configuration>
           <shadedArtifactAttached>false</shadedArtifactAttached>
+          <shadeTestJar>true</shadeTestJar>

Review Comment:
   Oh, it is trying to download many other test jars?
   We can remove this config. Originally I enabled it so that we have some shaded protobuf classes to experiment with. 
   
   We don't need it any more. We can use https://github.com/rangadi/shaded-protobuf-classes to create custom shaded jars. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org