You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ossie.apache.org by "ayushtkn (via GitHub)" <gi...@apache.org> on 2026/10/11 15:53:34 UTC
[PR] fix(python): give the non-finite diagnostic its missing verb [ossie]
ayushtkn opened a new pull request, #565:
URL: https://github.com/apache/ossie/pull/565
## Summary
Follow-up from on #563. The diagnostic was assembled as
`f"property {reason}: {paths}"`, which read as a sentence only for the null case:
before: property not a number JSON can represent, so it cannot round-trip: datasets[0].ai_context.score
after: property holds a number JSON cannot represent, so it cannot round-trip: datasets[0].ai_context.score
Each reason now carries its own subject, so it is a whole clause and the template adds
nothing. The null wording is unchanged — it already read correctly:
property set to null, which the schema does not allow; omit it instead: description
## Related Issues
<!-- Link any related GitHub issues: Closes #123, Fixes #456 -->
## Checklist
### Specification
- [ ] Spec changes are included in `core-spec/` and follow the existing structure
- [ ] Spec changes have been discussed on the mailing list or in a linked issue
- [ ] Breaking changes to the spec are clearly called out in the summary
### Ontology
- [ ] Ontology changes in `ontology/` are consistent with spec changes
- [ ] New or modified terms are defined and documented
### Converters
- [ ] Converter logic in `converters/` is updated to reflect spec or ontology changes
- [ ] New converters include tests under the converter's test directory
- [ ] If adding a new converter, `.github/labeler.yml` is updated with the new path
### Validation
- [ ] Validation rules in `validation/` are updated if the spec changed
- [ ] New validation cases are covered by tests
### Documentation
- [ ] `docs/` is updated to reflect any user-facing changes
- [ ] New features or behaviors are documented with examples where appropriate
- [ ] `CONTRIBUTING.md` is updated if the contribution process changed
### Examples
- [ ] `examples/` are added or updated for any new spec constructs or converter support
### Tests
- [ ] All existing tests pass (`pytest` / CI green)
- [ ] New functionality is covered by tests
### Compliance
- [ ] ASF license headers are present on all new source files
- [ ] No third-party dependencies are added without PMC/IPMC approval
- [ ] If third-party source code is vendored/copied (not just declared as a dependency), `NOTICE` and/or `LICENSE` have been updated per [ASF policy](https://infra.apache.org/licensing-howto.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(python): give the non-finite diagnostic its missing verb [ossie]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #565:
URL: https://github.com/apache/ossie/pull/565#discussion_r4242199833
##########
python/src/ossie/models.py:
##########
@@ -29,8 +29,9 @@
#: Paths listed in a diagnostic before the rest are counted instead.
_MAX_REPORTED = 20
-_NULL = "set to null, which the schema does not allow; omit it instead"
-_NON_FINITE = "not a number JSON can represent, so it cannot round-trip"
+# Each reads as a whole clause, so one can be followed by the paths it applies to.
+_NULL = "property set to null, which the schema does not allow; omit it instead"
+_NON_FINITE = "property holds a number JSON cannot represent, so it cannot round-trip"
Review Comment:
The existing loader tests only match the old substrings (`set to null` and `cannot round-trip`), so they would also pass with the malformed `property {reason}` composition this PR fixes. Please add assertions for the complete null and non-finite diagnostics so the subject/template coordination is covered against regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(python): give the non-finite diagnostic its missing verb [ossie]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre merged PR #565:
URL: https://github.com/apache/ossie/pull/565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ossie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org