You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/12 21:15:43 UTC
[GitHub] [beam] benWize opened a new pull request, #23195: GA Migration and Sharding Precommit Java IOs
benWize opened a new pull request, #23195:
URL: https://github.com/apache/beam/pull/23195
As part of the migration of Precommit and Postcommit Jobs from Jenkins to GA in self-hosted runners, this PR contains:
- Migrated and sharded workflow [job-precommit-java-mqtt-io.yml](https://github.com/benWize/beam/blob/88c5ba3e8649fd0f1661113c4ac6447fcb836d50/.github/workflows/job-precommit-java-mqtt-io.yml)
- Migrated and sharded workflow [job-precommit-java-parquet-io.yml](https://github.com/benWize/beam/blob/88c5ba3e8649fd0f1661113c4ac6447fcb836d50/.github/workflows/job-precommit-java-parquet-io.yml)
- Migrated and sharded workflow [job-precommit-java-pulsar-io.ymll](https://github.com/benWize/beam/blob/88c5ba3e8649fd0f1661113c4ac6447fcb836d50/.github/workflows/job-precommit-java-pulsar-io.yml)
- Migrated and sharded workflow [job-precommit-java-rabbitmq-io.yml](https://github.com/benWize/beam/blob/88c5ba3e8649fd0f1661113c4ac6447fcb836d50/.github/workflows/job-precommit-java-rabbitmq-io.yml)
- Migrated and sharded workflow [job-precommit-java-redis-io.yml](https://github.com/benWize/beam/blob/88c5ba3e8649fd0f1661113c4ac6447fcb836d50/.github/workflows/job-precommit-java-redis-io.yml)
The migrated workflows were added to [CI.md](https://github.com/benWize/beam/blob/88c5ba3e8649fd0f1661113c4ac6447fcb836d50/CI.md)
**DO NOT MERGE** until the effort to use **self-hosted runners** is completed https://github.com/apache/beam/pull/22703
These workflows use base actions listed in https://github.com/apache/beam/pull/23109 (Dependency)
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] benWize commented on pull request #23195: GA Migration and Sharding Precommit Java IOs
Posted by GitBox <gi...@apache.org>.
benWize commented on PR #23195:
URL: https://github.com/apache/beam/pull/23195#issuecomment-1244541192
Successful executions on self-hosted runners:
- MQTT: https://github.com/benWize/beam/actions/runs/3038852341
- Parquet: https://github.com/benWize/beam/actions/runs/3038852339
- Pulsar: https://github.com/benWize/beam/actions/runs/3038852331
- Redis IO: https://github.com/benWize/beam/actions/runs/3038852328
- RabbitMQ: https://github.com/benWize/beam/actions/runs/3038852327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23195: GA Migration and Sharding Precommit Java IOs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23195:
URL: https://github.com/apache/beam/pull/23195#issuecomment-1344267981
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] fernando-wizeline commented on pull request #23195: GA Migration and Sharding Precommit Java IOs
Posted by GitBox <gi...@apache.org>.
fernando-wizeline commented on PR #23195:
URL: https://github.com/apache/beam/pull/23195#issuecomment-1254253332
LGTM!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm closed pull request #23195: GA Migration and Sharding Precommit Java IOs
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm closed pull request #23195: GA Migration and Sharding Precommit Java IOs
URL: https://github.com/apache/beam/pull/23195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] benWize commented on a diff in pull request #23195: GA Migration and Sharding Precommit Java IOs
Posted by GitBox <gi...@apache.org>.
benWize commented on code in PR #23195:
URL: https://github.com/apache/beam/pull/23195#discussion_r981521871
##########
.github/workflows/job-precommit-java-mqtt-io.yml:
##########
@@ -0,0 +1,56 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This workflow will run MQTT IO Unit Tests in Java SDK
+
+name: Java MQTT IO
Review Comment:
These workflows are part of the sharding of the Java Precommit workflow, some of the modules will be placed in a new java precommit workflow in https://github.com/apache/beam/pull/23138, while some others will remain in the current Jenkins job, mainly due to the lack of support for some reports.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23195: GA Migration and Sharding Precommit Java IOs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23195:
URL: https://github.com/apache/beam/pull/23195#issuecomment-1256459371
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #23195: GA Migration and Sharding Precommit Java IOs
Posted by GitBox <gi...@apache.org>.
damccorm commented on code in PR #23195:
URL: https://github.com/apache/beam/pull/23195#discussion_r979453774
##########
CI.md:
##########
@@ -125,6 +125,33 @@ Service Account shall have following permissions ([IAM roles](https://cloud.goog
| Java Wordcount Direct Runner | Runs Java WordCount example with Direct Runner. | Yes | Yes | Yes | - |
| Java Wordcount Dataflow | Runs Java WordCount example with DataFlow Runner. | - | Yes | Yes | Yes |
+### PreCommit Workflows
+
+#### Java MQTT IO - [job-precommit-java-mqtt-io.yml](.github/workflows/job-precommit-java-mqtt-io.yml)
Review Comment:
Could we remove section headers and make this a single table?
##########
.github/workflows/job-precommit-java-mqtt-io.yml:
##########
@@ -0,0 +1,56 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# This workflow will run MQTT IO Unit Tests in Java SDK
+
+name: Java MQTT IO
Review Comment:
Should these workflows be removed from Jenkins?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23195: GA Migration and Sharding Precommit Java IOs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23195:
URL: https://github.com/apache/beam/pull/23195#issuecomment-1356785401
Reminder, please take a look at this pr: @damccorm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] benWize commented on a diff in pull request #23195: GA Migration and Sharding Precommit Java IOs
Posted by GitBox <gi...@apache.org>.
benWize commented on code in PR #23195:
URL: https://github.com/apache/beam/pull/23195#discussion_r981517190
##########
CI.md:
##########
@@ -125,6 +125,33 @@ Service Account shall have following permissions ([IAM roles](https://cloud.goog
| Java Wordcount Direct Runner | Runs Java WordCount example with Direct Runner. | Yes | Yes | Yes | - |
| Java Wordcount Dataflow | Runs Java WordCount example with DataFlow Runner. | - | Yes | Yes | Yes |
+### PreCommit Workflows
+
+#### Java MQTT IO - [job-precommit-java-mqtt-io.yml](.github/workflows/job-precommit-java-mqtt-io.yml)
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #23195: GA Migration and Sharding Precommit Java IOs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23195:
URL: https://github.com/apache/beam/pull/23195#issuecomment-1435662162
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org