You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bloodhound.apache.org by Andrej Golcov <an...@digiverse.si> on 2012/11/13 13:45:24 UTC
Re: [Apache Bloodhound] #207: Incorrect bold font weight for label of
radio ticket field
Hi,
It looks like labels for ticket custom radio field were not rendered inside
<label> tag in bloodhound theme.
Is there any reason for this?
If not, I suggest the following patch.
Regards, Andrej
===================================================================
--- bloodhound_theme/bhtheme/templates/bh_ticket.html (revision 1408673)
+++ bloodhound_theme/bhtheme/templates/bh_ticket.html (working copy)
@@ -369,7 +369,7 @@
py:with="value =
ticket.get_value_or_default(field.name)">
<th class="col${idx + 1}" py:if="idx == 0 or not
fullrow">
<label for="field-${field.name}" py:if="field"
- py:strip="field.type == 'radio'"
i18n:msg="field">${
+ i18n:msg="field">${
field.edit_label or field.label or field.name
}:</label>
</th>
<td class="col${idx + 1}" py:if="idx == 0 or not
fullrow"
Re: [Apache Bloodhound] #207: Incorrect bold font weight for label
of radio ticket field
Posted by Gary Martin <ga...@wandisco.com>.
Hi Andrej,
I can't see a particular reason for excluding radio fields here. I think
I will commit this change now and see if anyone complains!
Thanks for looking into that!
Cheers,
Gary
On 13/11/12 12:45, Andrej Golcov wrote:
> Hi,
>
> It looks like labels for ticket custom radio field were not rendered inside
> <label> tag in bloodhound theme.
> Is there any reason for this?
> If not, I suggest the following patch.
>
> Regards, Andrej
>
> ===================================================================
> --- bloodhound_theme/bhtheme/templates/bh_ticket.html (revision 1408673)
> +++ bloodhound_theme/bhtheme/templates/bh_ticket.html (working copy)
> @@ -369,7 +369,7 @@
> py:with="value =
> ticket.get_value_or_default(field.name)">
> <th class="col${idx + 1}" py:if="idx == 0 or not
> fullrow">
> <label for="field-${field.name}" py:if="field"
> - py:strip="field.type == 'radio'"
> i18n:msg="field">${
> + i18n:msg="field">${
> field.edit_label or field.label or field.name
> }:</label>
> </th>
> <td class="col${idx + 1}" py:if="idx == 0 or not
> fullrow"
>