You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "linliu-code (via GitHub)" <gi...@apache.org> on 2023/12/21 01:06:03 UTC
[PR] [HUDI-7229] support partial updates for cdc payload demo [hudi]
linliu-code opened a new pull request, #10384:
URL: https://github.com/apache/hudi/pull/10384
### Change Logs
Use MysqlDebeziumSource as an example to demonstrate the design.
### Impact
Low.
### Risk level (write none, low medium or high below)
None, just a demo.
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7229] support partial updates for cdc payload demo [hudi]
Posted by "bvaradar (via GitHub)" <gi...@apache.org>.
bvaradar commented on code in PR #10384:
URL: https://github.com/apache/hudi/pull/10384#discussion_r1445146024
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/SourceFormatAdapter.java:
##########
@@ -158,8 +160,9 @@ public InputBatch<JavaRDD<GenericRecord>> fetchNewDataInAvroFormat(Option<String
}
case ROW: {
//we do the sanitizing here if enabled
- InputBatch<Dataset<Row>> r = ((Source<Dataset<Row>>) source).fetchNext(lastCkptStr, sourceLimit);
- return new InputBatch<>(Option.ofNullable(r.getBatch().map(
+ // InputBatch<Dataset<Row>> r = ((Source<Dataset<Row>>) source).fetchNext(lastCkptStr, sourceLimit);
+ List<InputBatch<Dataset<Row>>> rs = ((Source<Dataset<Row>>) source).fetchNextForParitialUpdate(lastCkptStr, sourceLimit);
Review Comment:
Can you keep fetchNext as the main API to be called. Processing PartialUpdate or fullUpdate needs to be encapsulated inside the Source implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7229] support partial updates for cdc payload demo [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10384:
URL: https://github.com/apache/hudi/pull/10384#issuecomment-1865341758
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dc3cdf3ad2ea6666994be78af843c17a74ccacf1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "dc3cdf3ad2ea6666994be78af843c17a74ccacf1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dc3cdf3ad2ea6666994be78af843c17a74ccacf1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7229] support partial updates for cdc payload demo [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10384:
URL: https://github.com/apache/hudi/pull/10384#issuecomment-1865410801
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dc3cdf3ad2ea6666994be78af843c17a74ccacf1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21632",
"triggerID" : "dc3cdf3ad2ea6666994be78af843c17a74ccacf1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dc3cdf3ad2ea6666994be78af843c17a74ccacf1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21632)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7229] support partial updates for cdc payload demo [hudi]
Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #10384:
URL: https://github.com/apache/hudi/pull/10384#issuecomment-1865346516
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "dc3cdf3ad2ea6666994be78af843c17a74ccacf1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21632",
"triggerID" : "dc3cdf3ad2ea6666994be78af843c17a74ccacf1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* dc3cdf3ad2ea6666994be78af843c17a74ccacf1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=21632)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7229] support partial updates for cdc payload demo [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code closed pull request #10384: [HUDI-7229] support partial updates for cdc payload demo
URL: https://github.com/apache/hudi/pull/10384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-7229] support partial updates for cdc payload demo [hudi]
Posted by "linliu-code (via GitHub)" <gi...@apache.org>.
linliu-code commented on PR #10384:
URL: https://github.com/apache/hudi/pull/10384#issuecomment-1881811126
This is not a correct direction for cdc demo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org