[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6676: Nessie : use default namespace location if exists

["ajantha-bhat (via GitHub)" <gi...@apache.org>]

ajantha-bhat commented on code in PR #6676:
URL: https://github.com/apache/iceberg/pull/6676#discussion_r1088873536


##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java:
##########
@@ -202,7 +202,16 @@ protected TableOperations newTableOps(TableIdentifier tableIdentifier) {
   protected String defaultWarehouseLocation(TableIdentifier table) {
     String location;
     if (table.hasNamespace()) {
-      location = SLASH.join(warehouseLocation, table.namespace().toString(), table.name());
+      String baseLocation;
+      try {
+        baseLocation =
+            loadNamespaceMetadata(table.namespace())
+                .getOrDefault(
+                    "location", SLASH.join(warehouseLocation, table.namespace().toString()));

Review Comment:
   Thanks for the PR.
   
   How does the user know he needs to configure the namespace property as "location"? hive calls it a "database.locationUri" I guess. 
   
   I think we need to standardize it for all the catalogs or document the supported namespace properties per catalog. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org