[GitHub] [druid] uschindler commented on pull request #12158: Fix forbiddenapis causing travis failing

[GitBox <gi...@apache.org>]

uschindler commented on pull request #12158:
URL: https://github.com/apache/druid/pull/12158#issuecomment-1014595767


   Hi,
   
   my personal optinion here: From what I understand by default you use Guava 16.0 in your main dependecies. This one has the method still available (although deprecated after 18).
   
   In opentelemetry-emitter you seem to use another more modern Guava version 30.1.1. So it can't parse the signatures file, because the class is available, but not the method.
   
   I would cleanup by signatures file and put the Guava one in a separate file (or maybe inline it directly in the pom.xml on top-level scope). For https://github.com/apache/druid/blob/6a938725861f0cafbe97e5ff8c3417fe65405cca/extensions-contrib/opentelemetry-emitter/pom.xml, I'd change the forbiddenapis config to not use the extra guava signatures file, but for the default config in root pom use the signatures file.
   
   Uwe (from forbiddenapis)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org