You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "cmettler (via GitHub)" <gi...@apache.org> on 2025/03/11 18:31:11 UTC

[PR] Update FlightInfo.cs [arrow]

cmettler opened a new pull request, #45753:
URL: https://github.com/apache/arrow/pull/45753

   
   ### What changes are included in this PR?
   
   add ordered and AppMetaData to FlightInfo.cs [#45752](https://github.com/apache/arrow/issues/45752)
   
   ### Are these changes tested?
   
   YES
   
   ### Are there any user-facing changes?
   
   NO


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45752: [C#] Update FlightInfo.cs with missing fields [arrow]

Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on code in PR #45753:
URL: https://github.com/apache/arrow/pull/45753#discussion_r1992165936


##########
csharp/src/Apache.Arrow.Flight/FlightInfo.cs:
##########
@@ -1,4 +1,4 @@
-// Licensed to the Apache Software Foundation (ASF) under one or more
+// Licensed to the Apache Software Foundation (ASF) under one or more

Review Comment:
   It appears to be removing the "UTF-8 BOM". I don't know what the state of all the other source files is in this regard; I know that it's generally not recommended to use one (and I expect it's not required to compile C#) but I know there are definitely things in the Microsoft world that work better when there is one.
   
   On the whole, if we think we should get rid of these, we should probably do it for all the files in one change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45752: [C#] Update FlightInfo.cs with missing fields [arrow]

Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher merged PR #45753:
URL: https://github.com/apache/arrow/pull/45753


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45752: [C#] Update FlightInfo.cs with missing fields [arrow]

Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #45753:
URL: https://github.com/apache/arrow/pull/45753#issuecomment-2727962058

   After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit b2a9f98b07d18dffc0581eb43d838fd67103973d.
   
   There were no benchmark performance regressions. 🎉
   
   The [full Conbench report](https://github.com/apache/arrow/runs/38862504766) has more details. It also includes information about 8 possible false positives for unstable benchmarks that are known to sometimes produce them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45752: [C#] Update FlightInfo.cs with missing fields [arrow]

Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on code in PR #45753:
URL: https://github.com/apache/arrow/pull/45753#discussion_r1992157393


##########
csharp/src/Apache.Arrow.Flight/FlightInfo.cs:
##########
@@ -1,4 +1,4 @@
-// Licensed to the Apache Software Foundation (ASF) under one or more
+// Licensed to the Apache Software Foundation (ASF) under one or more

Review Comment:
   Can you please edit your PR so there's no diff in this area of the file?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Update FlightInfo.cs [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45753:
URL: https://github.com/apache/arrow/pull/45753#issuecomment-2715349952

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45752: [C#] Update FlightInfo.cs with missing fields [arrow]

Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on code in PR #45753:
URL: https://github.com/apache/arrow/pull/45753#discussion_r1992169691


##########
csharp/src/Apache.Arrow.Flight/FlightInfo.cs:
##########
@@ -1,4 +1,4 @@
-// Licensed to the Apache Software Foundation (ASF) under one or more
+// Licensed to the Apache Software Foundation (ASF) under one or more

Review Comment:
   Yeah, I wasn't aware this (and probably others) had BOMs. +1 to make any change in a dedicated PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45752: [C#] Update FlightInfo.cs with missing fields [arrow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45753:
URL: https://github.com/apache/arrow/pull/45753#issuecomment-2715363336

   :warning: GitHub issue #45752 **has been automatically assigned in GitHub** to PR creator.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45752: [C#] Update FlightInfo.cs with missing fields [arrow]

Posted by "CurtHagenlocher (via GitHub)" <gi...@apache.org>.
CurtHagenlocher commented on code in PR #45753:
URL: https://github.com/apache/arrow/pull/45753#discussion_r1993460921


##########
csharp/src/Apache.Arrow.Flight/FlightInfo.cs:
##########
@@ -38,15 +38,19 @@ internal FlightInfo(Protocol.FlightInfo flightInfo)
 
             TotalBytes = flightInfo.TotalBytes;
             TotalRecords = flightInfo.TotalRecords;
+            Ordered = flightInfo.Ordered;
+            AppMetadata = flightInfo.AppMetadata;
         }
 
-        public FlightInfo(Schema schema, FlightDescriptor descriptor, IReadOnlyList<FlightEndpoint> endpoints, long totalRecords = -1, long totalBytes = -1)
+        public FlightInfo(Schema schema, FlightDescriptor descriptor, IReadOnlyList<FlightEndpoint> endpoints, long totalRecords = -1, long totalBytes = -1, bool ordered = false, ByteString appMetadata=null)

Review Comment:
   This breaks binary compatibility, and there are scenarios where that matters. Could you add an overload with the additional parameters instead of changing the existing public constructor? The original constructor can chain to the new one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] GH-45752: [C#] Update FlightInfo.cs with missing fields [arrow]

Posted by "cmettler (via GitHub)" <gi...@apache.org>.
cmettler commented on code in PR #45753:
URL: https://github.com/apache/arrow/pull/45753#discussion_r1994108025


##########
csharp/src/Apache.Arrow.Flight/FlightInfo.cs:
##########
@@ -38,15 +38,19 @@ internal FlightInfo(Protocol.FlightInfo flightInfo)
 
             TotalBytes = flightInfo.TotalBytes;
             TotalRecords = flightInfo.TotalRecords;
+            Ordered = flightInfo.Ordered;
+            AppMetadata = flightInfo.AppMetadata;
         }
 
-        public FlightInfo(Schema schema, FlightDescriptor descriptor, IReadOnlyList<FlightEndpoint> endpoints, long totalRecords = -1, long totalBytes = -1)
+        public FlightInfo(Schema schema, FlightDescriptor descriptor, IReadOnlyList<FlightEndpoint> endpoints, long totalRecords = -1, long totalBytes = -1, bool ordered = false, ByteString appMetadata=null)

Review Comment:
   Yes Sure! Sorry for that, I am not a daily C# coder, and I need to warm up.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org