[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2820: Updates for Sql autocomplete WIP

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #2820:
URL: https://github.com/apache/netbeans/pull/2820#discussion_r607301210



##########
File path: ide/db.sql.editor/src/org/netbeans/modules/db/sql/editor/resources/layer.xml
##########
@@ -58,7 +58,7 @@
 
                 <folder name="FoldManager">
                     <file name="CustomFoldManager.instance">
-                	<attr name="position" intvalue="1200"/>
+                        <attr name="position" intvalue="1200"/>

Review comment:
       Please remove the unnecessary whitespace changes.

##########
File path: ide/db.sql.editor/src/org/netbeans/modules/db/sql/editor/completion/SQLCompletionProvider.java
##########
@@ -131,4 +264,93 @@ public void run() {
         TokenHierarchy<?> hierarchy = TokenHierarchy.get(doc);
         return hierarchy.tokenSequence(SQLTokenId.language());
     }
+        
+    private static class SqlNewConnectionFix implements Fix {

Review comment:
       This feels a bit strange. We don't put "Install JDK" options into the Java Sourcecode. Why is SQL different? 

##########
File path: ide/db.sql.editor/src/org/netbeans/modules/db/sql/editor/resources/Bundle.properties
##########
@@ -41,3 +41,4 @@ sql-keyword=Keyword
 sql-errors=Error
 sql-dot=Period
 
+LAB_db_sql_editor_annotation_warn="Select Connection from the combo box at the top of the SQL Editor window."

Review comment:
       This seems to be unused.

##########
File path: ide/db.sql.editor/src/org/netbeans/modules/db/sql/analyzer/SQLStatementAnalyzer.java
##########
@@ -239,6 +239,8 @@ protected QualIdent parseIdentifier() {
     }
 
     protected String getUnquotedIdentifier() {
+        if (quoter == null)
+            return "";

Review comment:
       As a new review was requested: this is still broken.

##########
File path: ide/db.sql.editor/src/org/netbeans/modules/db/sql/editor/completion/SQLCompletionQuery.java
##########
@@ -120,23 +120,37 @@ public void query(SQLCompletionResultSet resultSet, SQLCompletionEnv newEnv) {
 
     private void doQuery(final SQLCompletionEnv newEnv) {
         try {
+            // DB Connection available
+            if (dbconn != null) {

Review comment:
       If dbconn can't be set, all is save - that is the answer. This work is all about not having a connection, so I think it is warranted to be save about this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists