[jira] [Updated] (HADOOP-8933) test-patch.sh fails erroneously on platforms that can't build native

["Chris Nauroth (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HADOOP-8933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Nauroth updated HADOOP-8933:
----------------------------------

    Attachment: HADOOP-8933.patch

The attached patch introduces an optional --no-native flag.  By default, the script still builds native like usual.  With this optional flag, the script will not include -Pnative in the mvn calls.

I tested this on OS X and Ubuntu.  On OS X, test-patch.sh succeeds if I use --no-native.  On Ubuntu, I confirmed that it still builds libhadoop.so by default if you don't specify --no-native.

Jenkins will give this a -1 for lack of new tests.  That's because the patch only changes build scripts.

                
> test-patch.sh fails erroneously on platforms that can't build native
> --------------------------------------------------------------------
>
>                 Key: HADOOP-8933
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8933
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-8933.patch
>
>
> If a developer is working on a platform that can't build native (like OS X right now), then test-patch.sh will report the patch as a failure due to "The patch appears to cause the build to fail."  This is incorrect, because the developer's patch didn't cause the build to fail.  Adding an extra optional flag to test-patch.sh would help developers on these platforms.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira