You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Moonm3n (via GitHub)" <gi...@apache.org> on 2023/04/24 11:03:13 UTC
[GitHub] [doris] Moonm3n opened a new pull request, #19010: [Enhancement](storage engine) avoid deleting tablets on unused disk
Moonm3n opened a new pull request, #19010:
URL: https://github.com/apache/doris/pull/19010
# Proposed changes
Issue Number: #18982
I’ll handle this issue with 3 PRs, and this is PR1.
## Problem summary
Deleting data on a disk by be itself can be risky, especially if it is the only replica, as data loss may occur. Now, tablets on unused disks are not deleted when `StorageEngine::_start_disk_stat_monitor` is executed.
## Checklist(Required)
* [x] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [x] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on pull request #19010: [Enhancement](storage engine) avoid deleting tablets on unused disk
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on PR #19010:
URL: https://github.com/apache/doris/pull/19010#issuecomment-1533982082
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19010: [Enhancement](storage engine) avoid deleting tablets on unused disk
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19010:
URL: https://github.com/apache/doris/pull/19010#issuecomment-1527393475
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19010: [Enhancement](storage engine) avoid deleting tablets on unused disk
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19010:
URL: https://github.com/apache/doris/pull/19010#issuecomment-1527393418
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #19010: [Enhancement](storage engine) avoid deleting tablets on unused disk
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #19010:
URL: https://github.com/apache/doris/pull/19010#issuecomment-1519927371
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #19010: [Enhancement](storage engine) avoid deleting tablets on unused disk
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #19010:
URL: https://github.com/apache/doris/pull/19010
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org