You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/10 18:13:58 UTC
[GitHub] [arrow-rs] alamb commented on a change in pull request #1300: Add `DictionaryArray::try_new()` to create dictionaries from pre existing arrays
alamb commented on a change in pull request #1300:
URL: https://github.com/apache/arrow-rs/pull/1300#discussion_r803965759
##########
File path: arrow/src/array/array_dictionary.rs
##########
@@ -69,6 +86,27 @@ pub struct DictionaryArray<K: ArrowPrimitiveType> {
}
impl<'a, K: ArrowPrimitiveType> DictionaryArray<K> {
+ /// Attempt to create a new DictionaryArray with a specified keys
+ /// (dictionary) and values (indexes into that dictionary)
Review comment:
🤦 yes
```suggestion
/// (indexes into the dictionary) and values (dictionary)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org