You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/13 12:22:39 UTC
[GitHub] [incubator-doris] morningman commented on a diff in pull request #9013: [Enhancement] [Storage Vectorize] optimize BitmapRangeIterator.next_range()
morningman commented on code in PR #9013:
URL: https://github.com/apache/incubator-doris/pull/9013#discussion_r849419196
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -57,23 +57,38 @@ class SegmentIterator::BitmapRangeIterator {
// read next range into [*from, *to) whose size <= max_range_size.
// return false when there is no more range.
- bool next_range(uint32_t max_range_size, uint32_t* from, uint32_t* to) {
+ bool next_range(const uint32_t max_range_size, uint32_t* from, uint32_t* to) {
if (_eof) {
return false;
}
+
*from = _buf[_buf_pos];
- uint32_t range_size = 0, last_val;
- do {
- last_val = _buf[_buf_pos];
- _buf_pos++;
- range_size++;
- if (UNLIKELY(_buf_pos == _buf_size)) { // read next batch
- _read_next_batch();
- if (_eof) {
- break;
- }
- }
- } while (range_size < max_range_size && _buf[_buf_pos] == last_val + 1);
+ uint32_t range_size = 0;
+ uint32_t last_val = _buf[_buf_pos] - 1; // this initial value just make first batch valid
Review Comment:
is it posible that `_buf[_buf_pos] == 0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org