You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/11/21 06:18:16 UTC

[PR] upgrade rocksdbjni 20231121 [spark]

panbingkun opened a new pull request, #43924:
URL: https://github.com/apache/spark/pull/43924

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   -->
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   <!--
   If generative AI tooling has been used in the process of authoring this patch, please include the
   phrase: 'Generated-by: ' followed by the name of the tool and its version.
   If no, write 'No'.
   Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.8.1 [spark]

Posted by "ajanoni (via GitHub)" <gi...@apache.org>.
ajanoni commented on PR #43924:
URL: https://github.com/apache/spark/pull/43924#issuecomment-2730048218

   Hi guys. I am getting the SIGSEGV error in my spark structured streaming application deployed to AWS EMR 7.8.0.
   It seems not merged into Spark 3.5.x : https://github.com/apache/spark/blob/v3.5.4/pom.xml
   Is that expected? It is a blocking issue for my application. Is there a workaround for it?
   Thanks. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [Don't merge & review] Upgrade rocksdbjni 20231121 [spark]

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #43924:
URL: https://github.com/apache/spark/pull/43924#issuecomment-1882093161

   > Can we merge this one first?
   
   I think we can give it a try.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.8.1 [spark]

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #43924:
URL: https://github.com/apache/spark/pull/43924#issuecomment-1921232735

   Merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [Don't merge & review] Upgrade rocksdbjni 20231121 [spark]

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #43924:
URL: https://github.com/apache/spark/pull/43924#issuecomment-1820307677

   This PR will synchronize the Master every day and run twice a day to verify Core Crash issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [Don't merge & review] Upgrade rocksdbjni 20231121 [spark]

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43924:
URL: https://github.com/apache/spark/pull/43924#issuecomment-1851346632

   > > Has this test been completed? Can we upgrade to the new version now?
   > 
   > Let's continue to verify until the end of this week?
   
   ok


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.8.1 [spark]

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #43924:
URL: https://github.com/apache/spark/pull/43924#issuecomment-1918846591

   > Where are we on this one - any reason to believe we shouldn't merge?
   
   I think we can merge this version because it has undergone a long period of testing and validation.
   Let me rebase the master again and do the final verification.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [Don't merge & review] Upgrade rocksdbjni 20231121 [spark]

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #43924:
URL: https://github.com/apache/spark/pull/43924#issuecomment-1851344687

   > Has this test been completed? Can we upgrade to the new version now?
   
   Let's continue to verify until the end of this week?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [Don't merge & review] Upgrade rocksdbjni 20231121 [spark]

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #43924:
URL: https://github.com/apache/spark/pull/43924#discussion_r1411764191


##########
python/docs/source/user_guide/sql/index.rst:
##########
@@ -16,9 +16,9 @@
     under the License.
 
 
-=========
-Spark SQL
-=========
+========================
+Spark SQL and DataFrames

Review Comment:
   Okay, I mistakenly submitted some irrelevant documents, I will withdraw them immediately.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [Don't merge & review] Upgrade rocksdbjni 20231121 [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43924:
URL: https://github.com/apache/spark/pull/43924#issuecomment-1831101933

   Thank you so much, @panbingkun !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [Don't merge & review] Upgrade rocksdbjni 20231121 [spark]

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #43924:
URL: https://github.com/apache/spark/pull/43924#issuecomment-1831051103

   - 20231125
   https://github.com/panbingkun/spark/actions/runs/6987302202/job/19014769999
   RocksDBStateStoreStreamingAggregationSuite
   <img width="995" alt="image" src="https://github.com/apache/spark/assets/15246973/906e3dfb-5b3d-4b7d-901d-e84c952dda38">
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.8.1 [spark]

Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #43924: [SPARK-45110][BUILD] Upgrade rocksdbjni to 8.8.1
URL: https://github.com/apache/spark/pull/43924


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [Don't merge & review] Upgrade rocksdbjni 20231121 [spark]

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #43924:
URL: https://github.com/apache/spark/pull/43924#issuecomment-1882108688

   Let me add the results of org.apache.spark.sql.execution.benchmark.StateStoreBasicOperationsBenchmark.
   JDK17: 
   JDK21: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [Don't merge & review] Upgrade rocksdbjni 20231121 [spark]

Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #43924:
URL: https://github.com/apache/spark/pull/43924#issuecomment-1830229615

   Thank you for keeping tracking this, @panbingkun . How about Today's status?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [Don't merge & review] Upgrade rocksdbjni 20231121 [spark]

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #43924:
URL: https://github.com/apache/spark/pull/43924#issuecomment-1831061274

   > Thank you for keeping tracking this, @panbingkun . How about Today's status?
   @dongjoon-hyun 
   - From the past `11` test processes, no similar `fatal errors`  (https://github.com/apache/spark/pull/42862) have been found before.
   https://github.com/apache/spark/pull/42862#issuecomment-1715986788
   <img width="906" alt="image" src="https://github.com/apache/spark/assets/15246973/8b7a6b73-38e4-4980-bd16-2c4c1a8951ff">
   - Every day, I try to run at least one time after rebasing master, let's continue to observe for a few days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [Don't merge & review] Upgrade rocksdbjni 20231121 [spark]

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43924:
URL: https://github.com/apache/spark/pull/43924#issuecomment-1851302133

   Has this test been completed? Can we upgrade to the new version now?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [Don't merge & review] Upgrade rocksdbjni 20231121 [spark]

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #43924:
URL: https://github.com/apache/spark/pull/43924#discussion_r1411633877


##########
python/docs/source/user_guide/sql/index.rst:
##########
@@ -16,9 +16,9 @@
     under the License.
 
 
-=========
-Spark SQL
-=========
+========================
+Spark SQL and DataFrames

Review Comment:
   It seems that this change is unrelated to the current PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [Don't merge & review] Upgrade rocksdbjni 20231121 [spark]

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43924:
URL: https://github.com/apache/spark/pull/43924#issuecomment-1833577009

   hmm... @panbingkun Why is the upgrade target 8.6.7 instead of 8.7.3? Considering the timeline, 8.7.3 was already released when testing began. Are there any known issues with 8.7.3?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [Don't merge & review] Upgrade rocksdbjni 20231121 [spark]

Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #43924:
URL: https://github.com/apache/spark/pull/43924#issuecomment-1835044247

   > hmm... @panbingkun Why is the upgrade target 8.6.7 instead of 8.7.3? Considering the timeline, 8.7.3 was already released when testing began. Are there any known issues with 8.7.3?
   
   When I started this PR, I found that the release on GitHub(`8.7.3`) was inconsistent with the release on Maven Repo(`8.6.7`), so I chose the `8.6.7` version. Today, I checked and now the version has reached `8.8.1`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [Don't merge & review] Upgrade rocksdbjni 20231121 [spark]

Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #43924:
URL: https://github.com/apache/spark/pull/43924#issuecomment-1880997020

   Can we merge this one first?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org