You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/01/30 11:59:53 UTC
[GitHub] [cloudstack] ustcweizhou opened a new pull request #3855: kvm: Fix
router migration issue when router has control/public nics onother physical
network than guest
ustcweizhou opened a new pull request #3855: kvm: Fix router migration issue when router has control/public nics onother physical network than guest
URL: https://github.com/apache/cloudstack/pull/3855
## Description
<!--- Describe your changes in detail -->
In VM migration on KVM, libvirt qemu hook script will change the bridge name to bridges for guest networks. It works for user vm. However for virtual router, it has nics on control network and public network. If control/public use different physical networks than guest network, virtual router cannot be migrated.
Fixes: #2783
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
We have more than 1 physical networks and faced same issue before.
We have this change to fix the issue in old cloudstack versions.
I did not test in latest master or 4.13 but I believe it should work as well.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3855: kvm: Fix
router migration issue when router has control/public nics onother physical
network than guest
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3855: kvm: Fix router migration issue when router has control/public nics onother physical network than guest
URL: https://github.com/apache/cloudstack/pull/3855#issuecomment-580557732
<b>Trillian test result (tid-864)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 26674 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3855-t864-kvm-centos7.zip
Smoke tests completed. 77 look OK, 0 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3855: kvm: Fix router
migration issue when router has control/public nics onother physical
network than guest
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3855: kvm: Fix router migration issue when router has control/public nics onother physical network than guest
URL: https://github.com/apache/cloudstack/pull/3855#issuecomment-580397604
@blueorangutan test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3855: kvm: Fix
router migration issue when router has control/public nics onother physical
network than guest
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3855: kvm: Fix router migration issue when router has control/public nics onother physical network than guest
URL: https://github.com/apache/cloudstack/pull/3855#issuecomment-580353356
Packaging result: ✖centos6 ✔centos7 ✔debian. JID-720
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3855: kvm: Fix
router migration issue when router has control/public nics onother physical
network than guest
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3855: kvm: Fix router migration issue when router has control/public nics onother physical network than guest
URL: https://github.com/apache/cloudstack/pull/3855#issuecomment-580397616
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] DaanHoogland commented on issue #3855: kvm: Fix router
migration issue when router has control/public nics onother physical
network than guest
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on issue #3855: kvm: Fix router migration issue when router has control/public nics onother physical network than guest
URL: https://github.com/apache/cloudstack/pull/3855#issuecomment-580340410
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] blueorangutan commented on issue #3855: kvm: Fix
router migration issue when router has control/public nics onother physical
network than guest
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on issue #3855: kvm: Fix router migration issue when router has control/public nics onother physical network than guest
URL: https://github.com/apache/cloudstack/pull/3855#issuecomment-580340573
@DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [cloudstack] rhtyd merged pull request #3855: kvm: Fix router
migration issue when router has control/public nics onother physical
network than guest
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #3855: kvm: Fix router migration issue when router has control/public nics onother physical network than guest
URL: https://github.com/apache/cloudstack/pull/3855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services