You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@answer.apache.org by "EkkoKo (via GitHub)" <gi...@apache.org> on 2024/07/20 20:06:52 UTC
[I] Add an option to provide a SITE PORT like you can provide INSTALL PORT in the installation steps [incubator-answer]
EkkoKo opened a new issue, #1029:
URL: https://github.com/apache/incubator-answer/issues/1029
## Is your feature request related to a problem? Please describe
I'm currently running in an environment which disables by default running on port 80, yes even if the port is exposed in a container (relates to some internal functionality), I've discovered that the only way to set it up is by changing the `config.yaml` -> `server.http.addr` port value.
## Describe the solution you'd like
I would love to just have a field that allowed me to write the Site port in the installation steps.
## Describe alternatives you've considered
The alternative would be editing manually the `config.yaml` file which isn't that bad but adding it in the installation steps could be nicer.
## Notes
I'm more than willing to write a PR to add that functionality :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add an option to provide a SITE PORT like you can provide INSTALL PORT in the installation steps [incubator-answer]
Posted by "EkkoKo (via GitHub)" <gi...@apache.org>.
EkkoKo commented on issue #1029:
URL: https://github.com/apache/incubator-answer/issues/1029#issuecomment-2242639910
> @EkkoKo Thank you for your feedback. I do not recommend giving users the option to fill in during the installation process. Instead, I suggest providing an environment variable, similar to the `INSTALL_PORT`, that can specify the port to run (after installation). This should take precedence over the port specified in the configuration file.
Yeah I agree, I think it's way better and makes it more dynamic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add an option to provide a SITE PORT like you can provide INSTALL PORT in the installation steps [incubator-answer]
Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars commented on issue #1029:
URL: https://github.com/apache/incubator-answer/issues/1029#issuecomment-2242380954
@EkkoKo Thank you for your feedback. I do not recommend giving users the option to fill in during the installation process. Instead, I suggest providing an environment variable, similar to the `INSTALL_PORT`, that can specify the port to run (after installation). This should take precedence over the port specified in the configuration file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add an option to provide a SITE PORT like you can provide INSTALL PORT in the installation steps [incubator-answer]
Posted by "EkkoKo (via GitHub)" <gi...@apache.org>.
EkkoKo commented on issue #1029:
URL: https://github.com/apache/incubator-answer/issues/1029#issuecomment-2244783826
> > I'm more than willing to write a PR to add that functionality :)
>
> 👍 Cool, you can try it.
I'll get started on working on it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add an option to provide a SITE PORT like you can provide INSTALL PORT in the installation steps [incubator-answer]
Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars commented on issue #1029:
URL: https://github.com/apache/incubator-answer/issues/1029#issuecomment-2244417928
> I'm more than willing to write a PR to add that functionality :)
👍 Cool, you can try it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add an option to provide a SITE PORT like you can provide INSTALL PORT in the installation steps [incubator-answer]
Posted by "EkkoKo (via GitHub)" <gi...@apache.org>.
EkkoKo closed issue #1029: Add an option to provide a SITE PORT like you can provide INSTALL PORT in the installation steps
URL: https://github.com/apache/incubator-answer/issues/1029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add an option to provide a SITE PORT like you can provide INSTALL PORT in the installation steps [incubator-answer]
Posted by "EkkoKo (via GitHub)" <gi...@apache.org>.
EkkoKo commented on issue #1029:
URL: https://github.com/apache/incubator-answer/issues/1029#issuecomment-2244914372
@LinkinStars I've created a PR and would love some thoughts, (also I'm going to add documenation about the new environment variables in the docs too)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Add an option to provide a SITE PORT like you can provide INSTALL PORT in the installation steps [incubator-answer]
Posted by "EkkoKo (via GitHub)" <gi...@apache.org>.
EkkoKo commented on issue #1029:
URL: https://github.com/apache/incubator-answer/issues/1029#issuecomment-2250700357
Since the changes were merged, I'm closing this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org