You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "yujun777 (via GitHub)" <gi...@apache.org> on 2023/06/19 12:00:23 UTC
[GitHub] [doris] yujun777 opened a new pull request, #20996: [fix](dynamic partition) fix create hot partition failed without error response
yujun777 opened a new pull request, #20996:
URL: https://github.com/apache/doris/pull/20996
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
When no enough ssd storage && set hot partition num > 0, create table will fail.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1598879313
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1633450472
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1635244360
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.66 seconds
stream load tsv: 503 seconds loaded 74807831229 Bytes, about 141 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17169721563 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230714121733_clickbench_pr_178347.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1601080288
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1598176708
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1613378045
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1633481253
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 55.36 seconds
stream load tsv: 505 seconds loaded 74807831229 Bytes, about 141 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17161108305 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230713110846_clickbench_pr_177682.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1597057068
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1598994316
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1634369253
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1605529846
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1606532619
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1628641804
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1632393492
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1632305379
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1632373411
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 54.29 seconds
stream load tsv: 506 seconds loaded 74807831229 Bytes, about 140 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 66 seconds loaded 1101869774 Bytes, about 15 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17167401114 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230712193857_clickbench_pr_177223.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1634431949
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 50.35 seconds
stream load tsv: 505 seconds loaded 74807831229 Bytes, about 141 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17161169114 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230713231645_clickbench_pr_178157.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1624572790
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1613377933
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1598511468
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1605823895
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman commented on a diff in pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman commented on code in PR #20996:
URL: https://github.com/apache/doris/pull/20996#discussion_r1234096227
##########
fe/fe-core/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java:
##########
@@ -351,17 +348,12 @@ private ArrayList<AddPartitionClause> getAddPartitionClause(Database db, OlapTab
*/
private void setStorageMediumProperty(HashMap<String, String> partitionProperties,
DynamicPartitionProperty property, ZonedDateTime now, int hotPartitionNum, int offset) {
- if ((hotPartitionNum <= 0 || offset + hotPartitionNum <= 0) && !property.getStorageMedium()
+ if (hotPartitionNum <= 0 || offset + hotPartitionNum <= 0 || property.getStorageMedium()
.equalsIgnoreCase("ssd")) {
return;
}
- String cooldownTime;
- if (property.getStorageMedium().equalsIgnoreCase("ssd")) {
- cooldownTime = TimeUtils.longToTimeString(DataProperty.MAX_COOLDOWN_TIME_MS);
Review Comment:
why remove this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1633449283
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1633478663
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.58 seconds
stream load tsv: 501 seconds loaded 74807831229 Bytes, about 142 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17164874891 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230713110426_clickbench_pr_177676.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1610981765
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1613933394
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1618038601
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1635224815
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1632617086
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1630923935
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 53.63 seconds
stream load tsv: 504 seconds loaded 74807831229 Bytes, about 141 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17167598600 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230711222020_clickbench_pr_176635.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1598118972
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1602176813
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1628073284
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1632695458
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 49.76 seconds
stream load tsv: 507 seconds loaded 74807831229 Bytes, about 140 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.8 seconds inserted 10000000 Rows, about 347K ops/s
storage size: 17168140125 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230712225553_clickbench_pr_177424.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #20996:
URL: https://github.com/apache/doris/pull/20996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1608539338
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1634193722
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 52.35 seconds
stream load tsv: 505 seconds loaded 74807831229 Bytes, about 141 MB/s
stream load json: 19 seconds loaded 2358488459 Bytes, about 118 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17165227425 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230713205358_clickbench_pr_178073.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1634123318
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on a diff in pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on code in PR #20996:
URL: https://github.com/apache/doris/pull/20996#discussion_r1234643837
##########
fe/fe-core/src/main/java/org/apache/doris/clone/DynamicPartitionScheduler.java:
##########
@@ -351,17 +348,12 @@ private ArrayList<AddPartitionClause> getAddPartitionClause(Database db, OlapTab
*/
private void setStorageMediumProperty(HashMap<String, String> partitionProperties,
DynamicPartitionProperty property, ZonedDateTime now, int hotPartitionNum, int offset) {
- if ((hotPartitionNum <= 0 || offset + hotPartitionNum <= 0) && !property.getStorageMedium()
+ if (hotPartitionNum <= 0 || offset + hotPartitionNum <= 0 || property.getStorageMedium()
.equalsIgnoreCase("ssd")) {
return;
}
- String cooldownTime;
- if (property.getStorageMedium().equalsIgnoreCase("ssd")) {
- cooldownTime = TimeUtils.longToTimeString(DataProperty.MAX_COOLDOWN_TIME_MS);
Review Comment:
mistook assume that no cooldown time equals max cooldown time. rollback this function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1598026157
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1606348595
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] shuke987 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "shuke987 (via GitHub)" <gi...@apache.org>.
shuke987 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1601809506
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yujun777 commented on pull request #20996: [fix](dynamic partition) fix create hot partition failed without error response
Posted by "yujun777 (via GitHub)" <gi...@apache.org>.
yujun777 commented on PR #20996:
URL: https://github.com/apache/doris/pull/20996#issuecomment-1606972500
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org