You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "harshithasudhakar (via GitHub)" <gi...@apache.org> on 2023/04/07 16:12:25 UTC
[GitHub] [eventmesh] harshithasudhakar opened a new pull request, #3663: [ISSUE #3650]Some optimization of the code.[ConfigService]
harshithasudhakar opened a new pull request, #3663:
URL: https://github.com/apache/eventmesh/pull/3663
Fixes #3650
### Modifications
a. Replaced 'config == null ? false : config.monitor()' with 'config != null && config.monitor()' at line 84
b. Imported 'java.util.Objects'
Also, 'Objects.requireNonNull(resourceUrl)' at line 130
### Documentation
- Does this pull request introduce a new feature? No
- If yes, how is the feature documented? NA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on pull request #3663: [ISSUE #3650]Some optimization of the code.[ConfigService]
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #3663:
URL: https://github.com/apache/eventmesh/pull/3663#issuecomment-1502758167
`java.util.Objects` import order is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #3663: [ISSUE #3650]Some optimization of the code.[ConfigService]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3663:
URL: https://github.com/apache/eventmesh/pull/3663#issuecomment-1502864699
## [Codecov](https://codecov.io/gh/apache/eventmesh/pull/3663?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3663](https://codecov.io/gh/apache/eventmesh/pull/3663?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2d0ca99) into [master](https://codecov.io/gh/apache/eventmesh/commit/7f005243389d5c6a7942a35bbf6c5eb306cd9f01?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7f00524) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 2d0ca99 differs from pull request most recent head 646fadf. Consider uploading reports for the commit 646fadf to get more accurate results
```diff
@@ Coverage Diff @@
## master #3663 +/- ##
============================================
- Coverage 13.76% 13.74% -0.02%
Complexity 1291 1291
============================================
Files 571 571
Lines 29239 29232 -7
Branches 2885 2883 -2
============================================
- Hits 4024 4018 -6
+ Misses 24841 24838 -3
- Partials 374 376 +2
```
| [Impacted Files](https://codecov.io/gh/apache/eventmesh/pull/3663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../apache/eventmesh/common/config/ConfigService.java](https://codecov.io/gh/apache/eventmesh/pull/3663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvQ29uZmlnU2VydmljZS5qYXZh) | `45.00% <0.00%> (+0.55%)` | :arrow_up: |
| [.../eventmesh/runtime/admin/handler/EventHandler.java](https://codecov.io/gh/apache/eventmesh/pull/3663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvRXZlbnRIYW5kbGVyLmphdmE=) | `6.25% <0.00%> (+0.06%)` | :arrow_up: |
| [...ntmesh/runtime/admin/handler/TCPClientHandler.java](https://codecov.io/gh/apache/eventmesh/pull/3663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2hhbmRsZXIvVENQQ2xpZW50SGFuZGxlci5qYXZh) | `4.25% <0.00%> (ø)` | |
| [...re/protocol/http/processor/SubscribeProcessor.java](https://codecov.io/gh/apache/eventmesh/pull/3663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wcm9jZXNzb3IvU3Vic2NyaWJlUHJvY2Vzc29yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...esh/runtime/metrics/grpc/EventMeshGrpcMonitor.java](https://codecov.io/gh/apache/eventmesh/pull/3663?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL21ldHJpY3MvZ3JwYy9FdmVudE1lc2hHcnBjTW9uaXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
... and [7 files with indirect coverage changes](https://codecov.io/gh/apache/eventmesh/pull/3663/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #3663: [ISSUE #3650]Some optimization of the code.[ConfigService]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #3663:
URL: https://github.com/apache/eventmesh/pull/3663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org