[GitHub] [arrow] dragosmg commented on a change in pull request #11403: ARROW-14310: [R] Make expect_dplyr_equal() more intuitive

[GitBox <gi...@apache.org>]

dragosmg commented on a change in pull request #11403:
URL: https://github.com/apache/arrow/pull/11403#discussion_r730915513



##########
File path: r/tests/testthat/helper-expectation.R
##########
@@ -64,24 +65,31 @@ verify_output <- function(...) {
   testthat::verify_output(...)
 }
 
-#' @param expr A dplyr pipeline with `input` as its start
-#' @param tbl A tbl/df as reference, will make RB/Table with
-#' @param skip_record_batch string skip message, if should skip RB test
-#' @param skip_table string skip message, if should skip Table test
-#' @param warning string expected warning from the RecordBatch and Table paths,
+#' Compare dplyr binding

Review comment:
       For me the word "binding" is quite cryptic and doesn't clarify what the function does. What do you think about `expression`? As in `compare_dplyr_expression()`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org