[GitHub] [spark] linhongliu-db commented on a change in pull request #35653: [SPARK-38318][SQL] Skip view cyclic reference check if view is stored as logical plan

[GitBox <gi...@apache.org>]

linhongliu-db commented on a change in pull request #35653:
URL: https://github.com/apache/spark/pull/35653#discussion_r815554548



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
##########
@@ -614,7 +614,11 @@ object ViewHelper extends SQLConfHelper with Logging {
     }.getOrElse(false)
     if (replace && uncache) {
       logDebug(s"Try to uncache ${name.quotedString} before replacing.")
-      checkCyclicViewReference(analyzedPlan, Seq(name), name)
+      if (!conf.storeAnalyzedPlanForView) {

Review comment:
       Sure, I just want to be conservative in the first version. Because `!conf.storeAnalyzedPlanForView && originalText.nonEmpty` means dataset view will always skip cyclic check. It's consistent with 3.1 which is good. But I thought we should always block recursive views unless the user explicitly changes the flag (even if the recursive views work well).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org