[GitHub] [ofbiz-framework] adityasharma7 commented on a change in pull request #425: (OFBIZ-10093) Replace elrte with Trumbowyg

[GitBox <gi...@apache.org>]

adityasharma7 commented on a change in pull request #425:
URL: https://github.com/apache/ofbiz-framework/pull/425#discussion_r773615041



##########
File path: applications/content/widget/CommonScreens.xml
##########
@@ -33,6 +33,7 @@ under the License.
                 <set field="layoutSettings.companyName" from-field="uiLabelMap.ContentCompanyName" global="true"/>
                 <set field="layoutSettings.companySubtitle" from-field="uiLabelMap.ContentCompanySubtitle" global="true"/>
                 <set field="layoutSettings.styleSheets[]" value="/contentimages/css/contentForum.css" global="true"/>
+                <set field="layoutSettings.styleSheets[]" value="/contentimages/css/contentForum.css" global="true"/>

Review comment:
       Hello @bjugl 
   Thanks for your contribution!
   It seems you missed to updated the css path.

##########
File path: themes/common-theme/webapp/common/css/trumbowygCustom.css
##########
@@ -0,0 +1,642 @@
+/**

Review comment:
       @bjugl 
   Is there any custom styling we have added overriding the default styling of trumbowyg. If not, we could directly use the css files available in ui folder. WDYT?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org