[GitHub] [arrow] projjal commented on pull request #9724: ARROW-11986: [C++][Gandiva] Implement IN expressions for doubles and floats

[GitBox <gi...@apache.org>]

projjal commented on pull request #9724:
URL: https://github.com/apache/arrow/pull/9724#issuecomment-804140077


   > D:/a/arrow/arrow/cpp/src/gandiva/dex_visitor.h:65:16: error: 'virtual void gandiva::DexVisitor::Visit(const gandiva::InExprDexBase<long double>&)' cannot be overloaded with 'virtual void gandiva::DexVisitor::Visit(const gandiva::InExprDexBase<long double>&)'
   >    65 |   virtual void Visit(const InExprDexBase<double_t>& dex) = 0;
   >       |                ^~~~~
   > D:/a/arrow/arrow/cpp/src/gandiva/dex_visitor.h:64:16: note: previous declaration 'virtual void gandiva::DexVisitor::Visit(const gandiva::InExprDexBase<long double>&)'
   >    64 |   virtual void Visit(const InExprDexBase<float_t>& dex) = 0;
   
   @frank400  Can you try replacing all float_t and double_t with float and double as I mentioned before? Looks like in that environment both float_t and double_t are defined as long double.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org