You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by shzh zhao <ao...@gmail.com> on 2014/02/10 11:08:44 UTC

a mistake in drawingml.hxx?

in oox\inc\oox\export\drawingml.hxx
there is a line like
"#include <svx/escherex.hxx>

if you search 'escherex.hxx' ,you can find it in filter/inc/filter/msfilter.

can anyone fix this bug in the code base?

-- 



*mailto: *aoo.zhaoshzh@gmail.com <https://google.com/profiles>
<https://google.com/profiles>

Re: a mistake in drawingml.hxx?

Posted by shzh zhao <ao...@gmail.com>.
yes,I found it when working on the ooxml export.
I will fix it in this feature development.
thanks for your answer.


2014-02-10 18:40 GMT+08:00 Andre Fischer <aw...@gmail.com>:

> On 10.02.2014 11:08, shzh zhao wrote:
>
>> in oox\inc\oox\export\drawingml.hxx
>> there is a line like
>> "#include <svx/escherex.hxx>
>>
>> if you search 'escherex.hxx' ,you can find it in
>> filter/inc/filter/msfilter.
>>
>> can anyone fix this bug in the code base?
>>
>
> I assume you found this while working on the OOXML export?  This makes you
> the one who can best fix it :-)  Probably the escherex.hxx file got moved
> from svx/ to filter/ after the OOXML code was written and later abandoned.
>  That would mean that the obvious fix is to replace
>
> "#include <svx/escherex.hxx>
>
> with
>
> "#include <filter/msfilter/escherex.hxx>
>
> But, at the moment, you are probably the only one who can judge whether
> that works or not.
>
>
> -Andre
>
>
>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
> For additional commands, e-mail: dev-help@openoffice.apache.org
>
>


-- 



*mailto: *aoo.zhaoshzh@gmail.com <https://google.com/profiles>
<https://google.com/profiles>

Re: a mistake in drawingml.hxx?

Posted by Andre Fischer <aw...@gmail.com>.
On 10.02.2014 11:08, shzh zhao wrote:
> in oox\inc\oox\export\drawingml.hxx
> there is a line like
> "#include <svx/escherex.hxx>
>
> if you search 'escherex.hxx' ,you can find it in filter/inc/filter/msfilter.
>
> can anyone fix this bug in the code base?

I assume you found this while working on the OOXML export?  This makes 
you the one who can best fix it :-)  Probably the escherex.hxx file got 
moved from svx/ to filter/ after the OOXML code was written and later 
abandoned.  That would mean that the obvious fix is to replace

"#include <svx/escherex.hxx>

with

"#include <filter/msfilter/escherex.hxx>

But, at the moment, you are probably the only one who can judge whether that works or not.


-Andre

>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: a mistake in drawingml.hxx?

Posted by Herbert Duerr <hd...@apache.org>.
On 10.02.2014 11:08, shzh zhao wrote:
> in oox\inc\oox\export\drawingml.hxx
> there is a line like
> "#include <svx/escherex.hxx>
>
> if you search 'escherex.hxx' ,you can find it in filter/inc/filter/msfilter.

Yes, it was moved from svx to filter in October 2009 with issue 106421.

> can anyone fix this bug in the code base?

I guess this problem shows up now has to do with you working on enabling 
this export type. Is there an issue-id for that already? I'd like to use 
it for committing the header-include fix.

Herbert

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org