You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/08 18:13:00 UTC

[GitHub] [flink] zhijiangW opened a new pull request #9646: [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor

zhijiangW opened a new pull request #9646:  [FLINK-14004][task] Define SourceReader interface to verify the integration with StreamOneInputProcessor
URL: https://github.com/apache/flink/pull/9646
 
 
   ## What is the purpose of the change
   
   We already refactored the task input and output sides based on the new source characters in FLIP-27. In order to further verify that the new source reader could work well with the unified `StreamOneInputProcessor` in mailbox model, we implement a unit test for integrating the whole process. In detail:
       
   - Define `SourceReader` and `SourceOutput` relevant interfaces based on FLIP-27.
   - Implement an example of stateless `SourceReader` (bounded sequence of integers).
   - Define `SourceReaderOperator` to integrate the SourceReader with `StreamOneInputProcessor`.
   - Define `SourceReaderStreamTask` to execute the source input and implement a unit test for it.
   
   Note: This PR is based on #9478 and #9483 , so only review the last commit for this PR scope.
   
   ## Brief change log
   
   - Define `SourceReader` and `SourceOutput` relevant interfaces based on FLIP-27.
   - Define `AbstractDataOutput` as the base class for both source output and network output.
   - Refactor the previous processes based on `AbstractDataOutput`.
   - Define `SourceReaderOperator` to wrap the `SourceReader`.
   - Define `SourceReaderStreamTask` to generate the source input and output for `StreamOneInputProcessor`.
   
   ## Verifying this change
   
     - Added unit test in `SourceReaderStreamTaskTest` for verifying that the source reader could be integrated well with `StreamOneInputProcessor`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**yes** / no)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services