You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/09/18 02:00:52 UTC

[GitHub] [dolphinscheduler] lenboo commented on pull request #6253: [API][BUG] Fix new tenant name could be "default" (#6220)

lenboo commented on pull request #6253:
URL: https://github.com/apache/dolphinscheduler/pull/6253#issuecomment-922160283


   > > sorry for later comments.
   > > i think the 'default'(value=-1) cannot be removed.
   > > ```
   > > * if 'default' is removed,  you should must select one tenant when saving DAG.
   > >   I don't think this operation is as simple as 'default '.
   > > 
   > > * using 'default',  the same DAG can be run different tenants when multiple users run one DAG.
   > > ```
   > 
   > I know that 'default' should not be deleted, but when creating a new tenant, we can create a new one who's name is
   > 'default'. When saving the DAG, user should chose one tenant to run, when chosing tenant, there will be `TWO` tenant named 'default', it's hard to figure this two tenants who is the `REAL` 'default ' tenant reserved by dolphinscheduler.
   > 
   > So i created a pr #6222, trying to avoid user to create a tenant named 'default' in the back-end, user can still use 'default' tenant to run DAG, but the pr is not accepted, after talking about this issue with @JinyLeeChina , he said this issue should be resolved in the front-end. so i wonder what is the final solution....
   
   Thank you very much for your reply. 
   This problem is really complex and needs more discussion to find a suitable solution. 
   I suggest putting this issue in discussion and then finding a suitable solution
   
     报错 笔记


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org