You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by scop <gi...@git.apache.org> on 2016/06/13 15:50:14 UTC
[GitHub] activemq-artemis pull request #578: Update maven-checkstyle-plugin to 2.17, ...
GitHub user scop opened a pull request:
https://github.com/apache/activemq-artemis/pull/578
Update maven-checkstyle-plugin to 2.17, fix violations
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/scop/activemq-artemis checkstyle217
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/578.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #578
----
commit fb56cc7414592777d4e0f3d2ff0b7a5e3a592213
Author: Ville Skytt� <vi...@iki.fi>
Date: 2016-06-13T13:46:41Z
Update maven-checkstyle-plugin to 2.17
commit e4937480405d46a28ae36b4167c1680dd4a62386
Author: Ville Skytt� <vi...@iki.fi>
Date: 2016-06-13T15:21:43Z
Fix checkstyle curly brace violations
commit d0d023b26259a2c365b15a89ebbdf668d4ff87e1
Author: Ville Skytt� <vi...@iki.fi>
Date: 2016-06-13T15:22:33Z
Fix checkstyle whitespace violation
commit 676d2c0916ecce5db5adb92f2fd4e7c952de32b9
Author: Ville Skytt� <vi...@iki.fi>
Date: 2016-06-13T15:49:01Z
Fix checkstyle redundant modifier violations
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #578: Update maven-checkstyle-plugin to 2.17, fix vio...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/578
I would squash these commits and push -f on your branch
no need to have the checkstyles showing as committs after merge.
I could do it during merge though if you can't do it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #578: Update maven-checkstyle-plugin to 2.17, fix vio...
Posted by scop <gi...@git.apache.org>.
Github user scop commented on the issue:
https://github.com/apache/activemq-artemis/pull/578
Done, plus a few similar ones in examples.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #578: Update maven-checkstyle-plugin to 2.17, fix vio...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/578
(I have done a comment earlier here that I removed.. please ignore me.. I got confused about what this was about)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #578: Update maven-checkstyle-plugin to 2.17, ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/578
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #578: Update maven-checkstyle-plugin to 2.17, fix vio...
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on the issue:
https://github.com/apache/activemq-artemis/pull/578
@scop You have 1 checkstyle violation. Could you please update. Thanks.
[ERROR] src/test/java/org/apache/activemq/artemis/tests/extras/byteman/HierarchicalObjectRepositoryTest.java:[76,7] (modifier) RedundantModifier: Redundant 'public' modifier.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---