You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by shivaram <gi...@git.apache.org> on 2016/12/05 01:10:58 UTC

[GitHub] spark pull request #16014: [SPARK-18590][SPARKR] build R source package when...

Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16014#discussion_r90792485
  
    --- Diff: dev/make-distribution.sh ---
    @@ -71,6 +72,9 @@ while (( "$#" )); do
         --pip)
           MAKE_PIP=true
           ;;
    +    --r)
    +      MAKE_R=true
    --- End diff --
    
    FWIW if you want this to get picked up by the official release building procedure we also need to edit release-build.sh [1]. Can you coordinate this with @rxin ?
    
    [1] https://github.com/apache/spark/blob/d9eb4c7215f26dd05527c0b9980af35087ab9d64/dev/create-release/release-build.sh#L220


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org