[GitHub] [solr] thelabdude commented on a change in pull request #110: SOLR-11904: Mark ReplicationHandler's polling thread as a Solr server thread so the PKI Interceptor is activated to allow PULL replicas to replicate from security-enabled leaders

[GitBox <gi...@apache.org>]

thelabdude commented on a change in pull request #110:
URL: https://github.com/apache/solr/pull/110#discussion_r625431819



##########
File path: solr/core/src/test/org/apache/solr/cloud/TestPullReplica.java
##########
@@ -191,91 +270,56 @@ public void testCreateDelete() throws Exception {
     }
   }
 
-  /**
-   * Asserts that Update logs don't exist for replicas of type {@link org.apache.solr.common.cloud.Replica.Type#PULL}
-   */
-  private void assertUlogPresence(DocCollection collection) {
-    for (Slice s:collection.getSlices()) {
-      for (Replica r:s.getReplicas()) {
-        if (r.getType() == Replica.Type.NRT) {
-          continue;
-        }
-        SolrCore core = null;
-        try {
-          core = cluster.getReplicaJetty(r).getCoreContainer().getCore(r.getCoreName());
-          assertNotNull(core);
-          assertFalse("Update log should not exist for replicas of type Passive but file is present: " + core.getUlogDir(),
-              new java.io.File(core.getUlogDir()).exists());
-        } finally {
-          core.close();
-        }
-      }
-    }
-  }
-
   @SuppressWarnings("unchecked")
-  // 12-Jun-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
   public void testAddDocs() throws Exception {
-    int numPullReplicas = 1 + random().nextInt(3);
+    int numPullReplicas = 1; // + random().nextInt(3);

Review comment:
       test is flaky, so the whole test class is still disabled ... I tried to figure out what was causing the failures but couldn't nail it down




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org