[GitHub] egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing

[GitBox <gi...@apache.org>]

egor-ryashin commented on a change in pull request #7088: Improve parallelism of zookeeper based segment change processing
URL: https://github.com/apache/incubator-druid/pull/7088#discussion_r259438802
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinatorConfig.java
 ##########
 @@ -75,6 +75,10 @@ public String getLoadQueuePeonType()
     return "curator";
   }
 
+  @Config("druid.coordinator.curator.create.zknode.numThreads")
 
 Review comment:
   `curator` prefix already implies `zookeeper`, I vote for:
   `druid.coordinator.loadqueuepeon.curator.numThreads`
   
   or if other pool sizes will be configurable too then:
   `druid.coordinator.loadqueuepeon.curator.numCreateThreads`
   `druid.coordinator.loadqueuepeon.curator.numCallbackThreads`
   `druid.coordinator.loadqueuepeon.curator.numMonitorThreads`
   
   Also, it would be more clear if threads were named accordingly to parameter names, ie:
   `ZKNodeDeletionChecker-` -> `LoadQueuePeon-Monitor-`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org