You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/07 09:44:15 UTC
[GitHub] [kylin] zhangayqian opened a new pull request #1045: Fix error
judgment in PushDownExecutor.java
zhangayqian opened a new pull request #1045: Fix error judgment in PushDownExecutor.java
URL: https://github.com/apache/kylin/pull/1045
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] nichunen merged pull request #1045: Fix error judgment in
PushDownExecutor.java
Posted by GitBox <gi...@apache.org>.
nichunen merged pull request #1045: Fix error judgment in PushDownExecutor.java
URL: https://github.com/apache/kylin/pull/1045
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1045: Fix error judgment in
PushDownExecutor.java
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1045: Fix error judgment in PushDownExecutor.java
URL: https://github.com/apache/kylin/pull/1045#issuecomment-571535771
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1045?src=pr&el=h1) Report
> Merging [#1045](https://codecov.io/gh/apache/kylin/pull/1045?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/320c20f3db65a4d8fecc81d09832db79e44531f4?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/kylin/pull/1045?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1045 +/- ##
===========================================
+ Coverage 24.99% 25% +0.01%
- Complexity 6180 6181 +1
===========================================
Files 1438 1438
Lines 87669 87669
Branches 12257 12256 -1
===========================================
+ Hits 21913 21923 +10
+ Misses 63601 63595 -6
+ Partials 2155 2151 -4
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1045?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../org/apache/kylin/query/util/PushDownExecutor.java](https://codecov.io/gh/apache/kylin/pull/1045/diff?src=pr&el=tree#diff-cXVlcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3F1ZXJ5L3V0aWwvUHVzaERvd25FeGVjdXRvci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ream/core/storage/columnar/ColumnarStoreCache.java](https://codecov.io/gh/apache/kylin/pull/1045/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZUNhY2hlLmphdmE=) | `52.27% <0%> (-3.41%)` | `8% <0%> (ø)` | |
| [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1045/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | |
| [...he/kylin/job/impl/threadpool/DefaultScheduler.java](https://codecov.io/gh/apache/kylin/pull/1045/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdFNjaGVkdWxlci5qYXZh) | `76.74% <0%> (+2.32%)` | `12% <0%> (ø)` | :arrow_down: |
| [...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/1045/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh) | `70.21% <0%> (+3.64%)` | `7% <0%> (ø)` | :arrow_down: |
| [...org/apache/kylin/rest/util/QueryRequestLimits.java](https://codecov.io/gh/apache/kylin/pull/1045/diff?src=pr&el=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3QvdXRpbC9RdWVyeVJlcXVlc3RMaW1pdHMuamF2YQ==) | `40.47% <0%> (+4.76%)` | `6% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1045?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1045?src=pr&el=footer). Last update [320c20f...e1966cb](https://codecov.io/gh/apache/kylin/pull/1045?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] coveralls commented on issue #1045: Fix error judgment in
PushDownExecutor.java
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1045: Fix error judgment in PushDownExecutor.java
URL: https://github.com/apache/kylin/pull/1045#issuecomment-571536817
## Pull Request Test Coverage Report for [Build 5492](https://coveralls.io/builds/27954393)
* **0** of **2** **(0.0%)** changed or added relevant lines in **1** file are covered.
* **4** unchanged lines in **2** files lost coverage.
* Overall coverage increased (+**0.007%**) to **27.464%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [query/src/main/java/org/apache/kylin/query/util/PushDownExecutor.java](https://coveralls.io/builds/27954393/source?filename=query%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fquery%2Futil%2FPushDownExecutor.java#L62) | 0 | 2 | 0.0%
<!-- | **Total:** | **0** | **2** | **0.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/27954393/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
| [stream-core/src/main/java/org/apache/kylin/stream/core/storage/columnar/ColumnarStoreCache.java](https://coveralls.io/builds/27954393/source?filename=stream-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fstream%2Fcore%2Fstorage%2Fcolumnar%2FColumnarStoreCache.java#L80) | 2 | 57.95% |
<!-- | **Total:** | **4** | | -->
| Totals | [](https://coveralls.io/builds/27954393) |
| :-- | --: |
| Change from base [Build 5491](https://coveralls.io/builds/27950535): | 0.007% |
| Covered Lines: | 24077 |
| Relevant Lines: | 87669 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services