[GitHub] flink pull request #3176: [FLINK-5571] [table] add open and close methods fo...

[godfreyhe <gi...@git.apache.org>]

Github user godfreyhe commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3176#discussion_r99532146
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala ---
    @@ -220,56 +247,105 @@ class CodeGenerator(
         // manual casting here
         val samHeader =
           // FlatMapFunction
    -      if (clazz == classOf[FlatMapFunction[_,_]]) {
    +      if (clazz == classOf[FlatMapFunction[_, _]]) {
    --- End diff --
    
    We can not choose `FlatMapFunction` or `RichFlatMapFunction` in `translateToPlan` method, unless We know whether the current rexNode contains `UserDefinedFunction`s. However CodeGenerator is a kind of RexVisitor and know `UserDefinedFunction` when `generateExpression` called. 
    Besides, `RichFlatMapFunction` implements `FlatMapFunction`, so It's reasonable that Users call the generateFunction(desc, classOf[FlatMapFunction[Any, Any]], body, returnType) and returned a RichFlatMapFunction.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---