You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "amoeba (via GitHub)" <gi...@apache.org> on 2024/03/28 22:21:55 UTC
[PR] chore(dev/release): Fix Windows verification under conda [arrow-adbc]
amoeba opened a new pull request, #1684:
URL: https://github.com/apache/arrow-adbc/pull/1684
This changes two things to make release verification run on my system:
- Adds ` | Resolve-Path` to three variables to make them absolute paths. Without this, cpp_build.ps1 was running CMake and pointing at the wrong path because it saves a relative path, cds into another directory, and then tries to use the relative path.
- Adds `m2w64-gcc` inline to the `mamba create` call to make sure the Go has access to gcc for building. I was a little surprised the existing `compilers` package doesn't install gcc so I'm not sure if something might have changed upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(dev/release): Fix Windows verification under conda [arrow-adbc]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #1684:
URL: https://github.com/apache/arrow-adbc/pull/1684#issuecomment-2026332874
Ahh, okay. Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(dev/release): Fix Windows verification under conda [arrow-adbc]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #1684:
URL: https://github.com/apache/arrow-adbc/pull/1684#issuecomment-2026244332
Hrm, CI is failing with this change so maybe Resolve-Path isn't the fix. See https://github.com/apache/arrow-adbc/actions/runs/8474404990/job/23220717555#step:6:598.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(dev/release): Fix Windows verification under conda [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #1684:
URL: https://github.com/apache/arrow-adbc/pull/1684#issuecomment-2026268619
`Join-Path $ArrowTempDir cpp-build` should already be an absolute path anyways right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(dev/release): Fix Windows verification under conda [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #1684:
URL: https://github.com/apache/arrow-adbc/pull/1684#issuecomment-2026333153
https://github.com/conda-forge/compilers-feedstock/blob/main/recipe/meta.yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(dev/release): Fix Windows verification under conda [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #1684:
URL: https://github.com/apache/arrow-adbc/pull/1684#issuecomment-2026269971
`m2w64-gcc` might be us getting bitten by pre-installed stuff on runners. It's indeed necessary on Windows. That said the cmake-go-windows triplet is a huge problem anyways (https://github.com/conda-forge/arrow-adbc-split-feedstock/pull/17)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(dev/release): Fix Windows verification under conda [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #1684:
URL: https://github.com/apache/arrow-adbc/pull/1684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(dev/release): Fix Windows verification under conda [arrow-adbc]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #1684:
URL: https://github.com/apache/arrow-adbc/pull/1684#issuecomment-2026284389
> Join-Path $ArrowTempDir cpp-build should already be an absolute path anyways right?
Not on my system. It comes out as `verify-temp\apache-arrow-adbc-0.11.0`.
https://github.com/apache/arrow-adbc/blob/a1deb83ad2e1e997004f18917eb0c1f1c40896cb/dev/release/verify-release-candidate.ps1#L93
I think the above line just needs to modified to look like
https://github.com/apache/arrow-adbc/blob/a1deb83ad2e1e997004f18917eb0c1f1c40896cb/dev/release/verify-release-candidate.ps1#L91
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(dev/release): Fix Windows verification under conda [arrow-adbc]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #1684:
URL: https://github.com/apache/arrow-adbc/pull/1684#issuecomment-2026314483
I minimized the PR by pushing the Resolve-Path up and removing unneeded calls in https://github.com/apache/arrow-adbc/pull/1684/commits/1cf372ecc6dbe27d7e833ae6996c3aa0542227d8. Waiting to see what CI says.
Re: m2w64-gcc, I double-checked by creating a new conda env with just `compilers` and I don't get m2w64-gcc FWIW.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(dev/release): Fix Windows verification under conda [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #1684:
URL: https://github.com/apache/arrow-adbc/pull/1684#issuecomment-2026326822
On Windows, you use MSVC. Installing gcc is something we need to do extra. (I'm assuming we haven't noticed because runners probably came with it already.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(dev/release): Fix Windows verification under conda [arrow-adbc]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on PR #1684:
URL: https://github.com/apache/arrow-adbc/pull/1684#issuecomment-2026329760
go seems to look specifically for gcc when building what I assume is the go driver:
> cgo: C compiler "gcc" not found: exec: "gcc": executable file not found in %PATH%
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(dev/release): Fix Windows verification under conda [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #1684:
URL: https://github.com/apache/arrow-adbc/pull/1684#issuecomment-2026332575
Right, but I'm saying I wouldn't expect the conda compilers package to install much of anything on Windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org