[jira] [Updated] (ZOOKEEPER-412) checkstyle target fails trunk build

["Akihiro Suda (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ZOOKEEPER-412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Akihiro Suda updated ZOOKEEPER-412:
-----------------------------------
    Attachment: checkstyle-errors-trunk-20151211.html.gz
                ZOOKEEPER-412.patch


This still happens in trunk.

{panel}
$ rm -rf build
$ ant ivy-retrieve-test
$ ls -l build/test/lib/checkstyle-5.0.jar 
-rw-rw-r-- 1 suda suda 616230 Apr 18  2009 build/test/lib/checkstyle-5.0.jar
$ ant -v -Dcheckstyle.home=$(pwd)/build/test/lib checkstyle
..
checkstyle:
    [mkdir] Skipping /home/suda/WORK/zookeeper/build/test because it already exists.
[checkstyle] checkstyle version 5.0
[checkstyle] compiled on Sat April 18 2009, 11:45 EST
[checkstyle] log4j:WARN No appenders could be found for logger (org.apache.commons.beanutils.BeanUtils).
[checkstyle] log4j:WARN Please initialize the log4j system properly.
[checkstyle] log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for more info.
[checkstyle] Total execution took 97 ms.

BUILD FAILED
/home/suda/WORK/zookeeper/build.xml:1707: Unable to create a Checker: cannot initialize module PackageHtml - Unabl
e to instantiate PackageHtml
        at com.puppycrawl.tools.checkstyle.CheckStyleTask.createChecker(CheckStyleTask.java:383)
        at com.puppycrawl.tools.checkstyle.CheckStyleTask.realExecute(CheckStyleTask.java:300)
        at com.puppycrawl.tools.checkstyle.CheckStyleTask.execute(CheckStyleTask.java:262)
        at org.apache.tools.ant.UnknownElement.execute(UnknownElement.java:293)
        at sun.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:106)
...
{panel}

The bug is caused by {{PackageHtml}}, which has been removed since Checkstyle 5.0.
https://github.com/apache/zookeeper/blob/554e2997a0436f5f734ab9585ed88a63353d125b/src/java/test/checkstyle.xml#L38
http://sourceforge.net/p/eclipse-cs/discussion/274377/thread/9d8d3212/

I can come up with two possible solutions:

1. Keep current {{checkstyle.xml}}; use some old Checkstyle. (not sure which version is appropriate. it is not written in ZOOKEEPER-351)
2. Rewrite a new {{checkstyle.xml}}; switch to latest Checkstyle (6.13 at the moment)

I attached a patch ({{ZOOKEEPER-412.patch}}) for the latter one.

The {{checkstyle.xml}} included in {{ZOOKEEPER-412.patch}} is just copied from the latest Hadoop,
but I fear this may not comply with the original manner of ZooKeeper.

I also attached {{checkstyle-errors-trunk-20151211.html}} generated with the {{ZOOKEEPER-412.patch}}.
(over 60k style errors!)

Any thoughts?


> checkstyle target fails trunk build
> -----------------------------------
>
>                 Key: ZOOKEEPER-412
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-412
>             Project: ZooKeeper
>          Issue Type: Bug
>            Reporter: Giridharan Kesavan
>            Assignee: Thomas Koch
>         Attachments: ZOOKEEPER-412.patch, checkstyle-errors-trunk-20151211.html.gz
>
>
> BUILD FAILED
> /home/hudson/hudson-slave/workspace/ZooKeeper-trunk/trunk/build.xml:865: Unable to create a Checker: cannot initialize module PackageHtml - Unable to instantiate PackageHtml
> Tnx!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)