You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "David Jencks (JIRA)" <ji...@apache.org> on 2009/01/01 13:12:05 UTC

[jira] Created: (AMQ-2052) unsubscribing a durable subscriber does not properly clean up undelivered messages

unsubscribing a durable subscriber does not properly clean up undelivered messages
----------------------------------------------------------------------------------

                 Key: AMQ-2052
                 URL: https://issues.apache.org/activemq/browse/AMQ-2052
             Project: ActiveMQ
          Issue Type: Bug
          Components: Message Store
    Affects Versions: 5.3.0
            Reporter: David Jencks
            Assignee: David Jencks
             Fix For: 5.3.0


Working on the tck I found a lot of messages like 
2008-12-25 11:37:08,567 ERROR [RecoveryListenerAdapter] Message id ID:pb.local-56923-1230232035140-2:13:1:1:1 could not be recovered from the data store - already dispatched
in the log.  I can reproduce this with the attached test case (It could probably be in a better module, but I started looking here.)

To see the error put a breakpoint at RecoveryListenerAdapter line 61 and run the test.  The required steps to reproduce seem to be:

1. create a durable subscriber on a topic.
2. send a message to the topic.
3. close the subscriber and unsubscribe.
4. create a new durable subscriber on the same topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (AMQ-2052) unsubscribing a durable subscriber does not properly clean up undelivered messages

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Jencks updated AMQ-2052:
------------------------------

    Attachment: AMQ-2052-test.patch

Test case to deomonstrate the problem.  Note that the test passes, you have to put a breakpoint to see the problem.

> unsubscribing a durable subscriber does not properly clean up undelivered messages
> ----------------------------------------------------------------------------------
>
>                 Key: AMQ-2052
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2052
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Message Store
>    Affects Versions: 5.3.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 5.3.0
>
>         Attachments: AMQ-2052-test.patch
>
>
> Working on the tck I found a lot of messages like 
> 2008-12-25 11:37:08,567 ERROR [RecoveryListenerAdapter] Message id ID:pb.local-56923-1230232035140-2:13:1:1:1 could not be recovered from the data store - already dispatched
> in the log.  I can reproduce this with the attached test case (It could probably be in a better module, but I started looking here.)
> To see the error put a breakpoint at RecoveryListenerAdapter line 61 and run the test.  The required steps to reproduce seem to be:
> 1. create a durable subscriber on a topic.
> 2. send a message to the topic.
> 3. close the subscriber and unsubscribe.
> 4. create a new durable subscriber on the same topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQ-2052) unsubscribing a durable subscriber does not properly clean up undelivered messages

Posted by "Jim Taylor (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52372#action_52372 ] 

Jim Taylor commented on AMQ-2052:
---------------------------------

What is the work around after the store gets into this state? Is there one?

> unsubscribing a durable subscriber does not properly clean up undelivered messages
> ----------------------------------------------------------------------------------
>
>                 Key: AMQ-2052
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2052
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Message Store
>    Affects Versions: 5.3.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 5.3.0
>
>         Attachments: AMQ-2052-test.patch
>
>
> Working on the tck I found a lot of messages like 
> 2008-12-25 11:37:08,567 ERROR [RecoveryListenerAdapter] Message id ID:pb.local-56923-1230232035140-2:13:1:1:1 could not be recovered from the data store - already dispatched
> in the log.  I can reproduce this with the attached test case (It could probably be in a better module, but I started looking here.)
> To see the error put a breakpoint at RecoveryListenerAdapter line 61 and run the test.  The required steps to reproduce seem to be:
> 1. create a durable subscriber on a topic.
> 2. send a message to the topic.
> 3. close the subscriber and unsubscribe.
> 4. create a new durable subscriber on the same topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQ-2052) unsubscribing a durable subscriber does not properly clean up undelivered messages

Posted by "Gary Tully (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=52484#action_52484 ] 

Gary Tully commented on AMQ-2052:
---------------------------------

David, are you done with this or is there more work needed to get the tck passing?

> unsubscribing a durable subscriber does not properly clean up undelivered messages
> ----------------------------------------------------------------------------------
>
>                 Key: AMQ-2052
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2052
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Message Store
>    Affects Versions: 5.3.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 5.3.0
>
>         Attachments: AMQ-2052-test.patch
>
>
> Working on the tck I found a lot of messages like 
> 2008-12-25 11:37:08,567 ERROR [RecoveryListenerAdapter] Message id ID:pb.local-56923-1230232035140-2:13:1:1:1 could not be recovered from the data store - already dispatched
> in the log.  I can reproduce this with the attached test case (It could probably be in a better module, but I started looking here.)
> To see the error put a breakpoint at RecoveryListenerAdapter line 61 and run the test.  The required steps to reproduce seem to be:
> 1. create a durable subscriber on a topic.
> 2. send a message to the topic.
> 3. close the subscriber and unsubscribe.
> 4. create a new durable subscriber on the same topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQ-2052) unsubscribing a durable subscriber does not properly clean up undelivered messages

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48429#action_48429 ] 

David Jencks commented on AMQ-2052:
-----------------------------------

One more major file name problem... rev 730817.  Surprisingly this only caused 13 test failures.

> unsubscribing a durable subscriber does not properly clean up undelivered messages
> ----------------------------------------------------------------------------------
>
>                 Key: AMQ-2052
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2052
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Message Store
>    Affects Versions: 5.3.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 5.3.0
>
>         Attachments: AMQ-2052-test.patch
>
>
> Working on the tck I found a lot of messages like 
> 2008-12-25 11:37:08,567 ERROR [RecoveryListenerAdapter] Message id ID:pb.local-56923-1230232035140-2:13:1:1:1 could not be recovered from the data store - already dispatched
> in the log.  I can reproduce this with the attached test case (It could probably be in a better module, but I started looking here.)
> To see the error put a breakpoint at RecoveryListenerAdapter line 61 and run the test.  The required steps to reproduce seem to be:
> 1. create a durable subscriber on a topic.
> 2. send a message to the topic.
> 3. close the subscriber and unsubscribe.
> 4. create a new durable subscriber on the same topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (AMQ-2052) unsubscribing a durable subscriber does not properly clean up undelivered messages

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Jencks reopened AMQ-2052:
-------------------------------


Code inspection shows there are still a lot more confusions about when to use a file system safened name.

> unsubscribing a durable subscriber does not properly clean up undelivered messages
> ----------------------------------------------------------------------------------
>
>                 Key: AMQ-2052
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2052
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Message Store
>    Affects Versions: 5.3.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 5.3.0
>
>         Attachments: AMQ-2052-test.patch
>
>
> Working on the tck I found a lot of messages like 
> 2008-12-25 11:37:08,567 ERROR [RecoveryListenerAdapter] Message id ID:pb.local-56923-1230232035140-2:13:1:1:1 could not be recovered from the data store - already dispatched
> in the log.  I can reproduce this with the attached test case (It could probably be in a better module, but I started looking here.)
> To see the error put a breakpoint at RecoveryListenerAdapter line 61 and run the test.  The required steps to reproduce seem to be:
> 1. create a durable subscriber on a topic.
> 2. send a message to the topic.
> 3. close the subscriber and unsubscribe.
> 4. create a new durable subscriber on the same topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AMQ-2052) unsubscribing a durable subscriber does not properly clean up undelivered messages

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Jencks resolved AMQ-2052.
-------------------------------

    Resolution: Fixed

The actual problem causing this is confusion over when to use a file-system-safened ID.  Fixed in rev 730596.

I'm also changing the RecoveryListenerAdapter to throw an exception when it gets into this inconsistent state. Rev 730598.

I may try to simplify when and where the file system safening occurs.  I also plan to move the test case to a better location.

> unsubscribing a durable subscriber does not properly clean up undelivered messages
> ----------------------------------------------------------------------------------
>
>                 Key: AMQ-2052
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2052
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Message Store
>    Affects Versions: 5.3.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 5.3.0
>
>         Attachments: AMQ-2052-test.patch
>
>
> Working on the tck I found a lot of messages like 
> 2008-12-25 11:37:08,567 ERROR [RecoveryListenerAdapter] Message id ID:pb.local-56923-1230232035140-2:13:1:1:1 could not be recovered from the data store - already dispatched
> in the log.  I can reproduce this with the attached test case (It could probably be in a better module, but I started looking here.)
> To see the error put a breakpoint at RecoveryListenerAdapter line 61 and run the test.  The required steps to reproduce seem to be:
> 1. create a durable subscriber on a topic.
> 2. send a message to the topic.
> 3. close the subscriber and unsubscribe.
> 4. create a new durable subscriber on the same topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (AMQ-2052) unsubscribing a durable subscriber does not properly clean up undelivered messages

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/AMQ-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=48414#action_48414 ] 

David Jencks commented on AMQ-2052:
-----------------------------------

I think rev 730614 is an OK fix.... still need the test case.

> unsubscribing a durable subscriber does not properly clean up undelivered messages
> ----------------------------------------------------------------------------------
>
>                 Key: AMQ-2052
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2052
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Message Store
>    Affects Versions: 5.3.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 5.3.0
>
>         Attachments: AMQ-2052-test.patch
>
>
> Working on the tck I found a lot of messages like 
> 2008-12-25 11:37:08,567 ERROR [RecoveryListenerAdapter] Message id ID:pb.local-56923-1230232035140-2:13:1:1:1 could not be recovered from the data store - already dispatched
> in the log.  I can reproduce this with the attached test case (It could probably be in a better module, but I started looking here.)
> To see the error put a breakpoint at RecoveryListenerAdapter line 61 and run the test.  The required steps to reproduce seem to be:
> 1. create a durable subscriber on a topic.
> 2. send a message to the topic.
> 3. close the subscriber and unsubscribe.
> 4. create a new durable subscriber on the same topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (AMQ-2052) unsubscribing a durable subscriber does not properly clean up undelivered messages

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/AMQ-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Jencks closed AMQ-2052.
-----------------------------

    Resolution: Fixed

I've fixed all the problems I can find related to this so I'm closing this.

> unsubscribing a durable subscriber does not properly clean up undelivered messages
> ----------------------------------------------------------------------------------
>
>                 Key: AMQ-2052
>                 URL: https://issues.apache.org/activemq/browse/AMQ-2052
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: Message Store
>    Affects Versions: 5.3.0
>            Reporter: David Jencks
>            Assignee: David Jencks
>             Fix For: 5.3.0
>
>         Attachments: AMQ-2052-test.patch
>
>
> Working on the tck I found a lot of messages like 
> 2008-12-25 11:37:08,567 ERROR [RecoveryListenerAdapter] Message id ID:pb.local-56923-1230232035140-2:13:1:1:1 could not be recovered from the data store - already dispatched
> in the log.  I can reproduce this with the attached test case (It could probably be in a better module, but I started looking here.)
> To see the error put a breakpoint at RecoveryListenerAdapter line 61 and run the test.  The required steps to reproduce seem to be:
> 1. create a durable subscriber on a topic.
> 2. send a message to the topic.
> 3. close the subscriber and unsubscribe.
> 4. create a new durable subscriber on the same topic.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.