[GitHub] [apisix] Firstsawyou commented on a change in pull request #2599: Plugins(Doc): Optimize the document for hmac-auth

[GitBox <gi...@apache.org>]

Firstsawyou commented on a change in pull request #2599:
URL: https://github.com/apache/apisix/pull/2599#discussion_r516384100



##########
File path: doc/plugins/hmac-auth.md
##########
@@ -205,3 +209,201 @@ $ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f
     }
 }'
 ```
+
+## Generate Signature Examples
+
+Take HMAC SHA256 as an example to introduce the signature generation examples in different languages.
+
+Example inputs:
+Variable | Value
+---|---
+secret | this is secret key
+message | this is signature string
+
+Example outputs:
+Type | Hash
+---|---
+hexit | ad1b76c7e5054009380edca35d3f36cc5b6f45c82ee02ea3af64197ebddb9345
+base64 | rRt2x+UFQAk4DtyjXT82zFtvRcgu4C6jr2QZfr3bk0U=
+
+### Python 3

Review comment:
       I think these code examples are good in this file, so it is more intuitive. If the document is placed in a different location, it is easy for users to miss it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org