is there a good reason we don't just use github?

[Greg Hill <gr...@RACKSPACE.COM>]

Hey,

I'm new, so apologies if this has been discussed to death.  Is there a reason we don't just use github for doing code submissions/review?  The pull-request model is so much nicer than adding patches to JIRA and manually creating Review Board reviews and then linking them together.  Github can even add callbacks to automatically update the JIRA tickets when pull-requests are merged, etc.  The code's already there on github anyway, so people kind of expect to be able to submit pull-requests in a modern fashion. You can still limit core committers by only giving commit access to specific people.  And people then get credit for their contributions as well, where the current procedure gives credit only to the committer.

The current procedure is a pretty big barrier to entry for new contributors who would rather just focus on the code, and for people who would like to get credit for their work.

Greg

Re: is there a good reason we don't just use github?

[jun aoki <ju...@gmail.com>]

+1 to Greg's suggestion, it would be also nice to see issues are tracked by
Github instead of Apache Jira.


On Thu, Aug 7, 2014 at 6:48 AM, Greg Hill <gr...@rackspace.com> wrote:

>
>
> On 8/6/14 12:24 PM, "Yusaku Sako" <yu...@hortonworks.com> wrote:
>
>
> >Apache Git and Github integration is a relatively new feature (see
> >[1]) and we haven't really looked into it so far, but it might be
> >nicer to be able to make pull requests on Github, etc., in a more
> >convenient, modern fashion.
>
>
> The github code review tools are just so much better, IMO, and submitting
> a pull-request is a lot nicer than manually creating a patch and uploading
> it to two different systems.
>
> I'd be willing to help beta test things if people who can change things
> want to give it a shot.  Sounds like it won't be as simple as merging the
> pull-request from the committer's perspective, but if I can just open a
> JIRA then submit a pull-request with a comment pointing it at the JIRA
> ticket, that's a much nicer experience for me as a contributor.
>
> >
> >> And people then get credit for their contributions as well, where the
> >>current procedure gives credit only to the committer.
> >
> >As far as non-committers getting credit for their contributions,
> >that's always been the case.  They do get credit on Ambari JIRAs
> >(being the assignee of a JIRA marked "Fixed") as well as in the commit
> >log.
> >Do you mean the code contributions being reflected in the
> >contributors' Github profile and such?
>
> Yes, basically.  Github profiles are becoming basically a developer's
> portfolio, so being publicly credited for their work is an important
> factor to get right.  It also helps for people debugging to be able to use
> git blame to see who they might need to talk to to understand a part of
> code they are having trouble with.
>
> Greg
>
>
>


-- 
-jun

Re: is there a good reason we don't just use github?

[Greg Hill <gr...@RACKSPACE.COM>]

On 8/6/14 12:24 PM, "Yusaku Sako" <yu...@hortonworks.com> wrote:


>Apache Git and Github integration is a relatively new feature (see
>[1]) and we haven't really looked into it so far, but it might be
>nicer to be able to make pull requests on Github, etc., in a more
>convenient, modern fashion.


The github code review tools are just so much better, IMO, and submitting
a pull-request is a lot nicer than manually creating a patch and uploading
it to two different systems.

I'd be willing to help beta test things if people who can change things
want to give it a shot.  Sounds like it won't be as simple as merging the
pull-request from the committer's perspective, but if I can just open a
JIRA then submit a pull-request with a comment pointing it at the JIRA
ticket, that's a much nicer experience for me as a contributor.

>
>> And people then get credit for their contributions as well, where the
>>current procedure gives credit only to the committer.
>
>As far as non-committers getting credit for their contributions,
>that's always been the case.  They do get credit on Ambari JIRAs
>(being the assignee of a JIRA marked "Fixed") as well as in the commit
>log.
>Do you mean the code contributions being reflected in the
>contributors' Github profile and such?

Yes, basically.  Github profiles are becoming basically a developer's
portfolio, so being publicly credited for their work is an important
factor to get right.  It also helps for people debugging to be able to use
git blame to see who they might need to talk to to understand a part of
code they are having trouble with.

Greg

Re: is there a good reason we don't just use github?

[Yusaku Sako <yu...@hortonworks.com>]

Hi Greg,

That is an interesting question, and no, this has not been previously
discussed on the Ambari mailing lists.
Apache Git and Github integration is a relatively new feature (see
[1]) and we haven't really looked into it so far, but it might be
nicer to be able to make pull requests on Github, etc., in a more
convenient, modern fashion.

> You can still limit core committers by only giving commit access to specific people.
Even with the integration enabled, Ambari on Github will remain just a
mirror, so yes, committers would remain only ones who can commit.
However, we would be able to link pull requests to Ambari JIRAs per [1].

> And people then get credit for their contributions as well, where the current procedure gives credit only to the committer.

As far as non-committers getting credit for their contributions,
that's always been the case.  They do get credit on Ambari JIRAs
(being the assignee of a JIRA marked "Fixed") as well as in the commit
log.
Do you mean the code contributions being reflected in the
contributors' Github profile and such?

[1] https://blogs.apache.org/infra/entry/improved_integration_between_apache_and

Yusaku

On Wed, Aug 6, 2014 at 7:01 AM, Greg Hill <gr...@rackspace.com> wrote:
> Hey,
>
> I'm new, so apologies if this has been discussed to death.  Is there a reason we don't just use github for doing code submissions/review?  The pull-request model is so much nicer than adding patches to JIRA and manually creating Review Board reviews and then linking them together.  Github can even add callbacks to automatically update the JIRA tickets when pull-requests are merged, etc.  The code's already there on github anyway, so people kind of expect to be able to submit pull-requests in a modern fashion. You can still limit core committers by only giving commit access to specific people.  And people then get credit for their contributions as well, where the current procedure gives credit only to the committer.
>
> The current procedure is a pretty big barrier to entry for new contributors who would rather just focus on the code, and for people who would like to get credit for their work.
>
> Greg
>
>

-- 
CONFIDENTIALITY NOTICE
NOTICE: This message is intended for the use of the individual or entity to 
which it is addressed and may contain information that is confidential, 
privileged and exempt from disclosure under applicable law. If the reader 
of this message is not the intended recipient, you are hereby notified that 
any printing, copying, dissemination, distribution, disclosure or 
forwarding of this communication is strictly prohibited. If you have 
received this communication in error, please contact the sender immediately 
and delete it from your system. Thank You.