You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@predictionio.apache.org by shimamoto <gi...@git.apache.org> on 2017/10/13 08:20:25 UTC

[GitHub] incubator-predictionio-template-java-ecom-recommender pull request #6: 0.12....

GitHub user shimamoto opened a pull request:

    https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6

    0.12.0-incubating release

    Oh, there isn't a development branch... use master
    
    Checking document...

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shimamoto/incubator-predictionio-template-java-ecom-recommender release-0.12.0-incubating

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6
    
----
commit 358d83f285e0c2c73fc3dbc1e945051c1bea530f
Author: shimamoto <sh...@apache.org>
Date:   2017-10-13T08:01:47Z

    0.12.0-incubating release

----


---

[GitHub] incubator-predictionio-template-java-ecom-recommender pull request #6: 0.12....

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6


---

[GitHub] incubator-predictionio-template-java-ecom-recommender issue #6: 0.12.0-incub...

Posted by takezoe <gi...@git.apache.org>.
Github user takezoe commented on the issue:

    https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6
  
    @pferrel It looks to be impossible to solve in the current template mechanism. I believe that keeping templates for the latest and default stack is the best in the current mechanism. It might have to be documented to prevent confusion of users, or we might have to consider a solution to solve it, but I think it's an another topic in either case.
    
    Anyway, this pull request looks good to me, so I'm going to merge. Is this all right with you?


---

[GitHub] incubator-predictionio-template-java-ecom-recommender issue #6: 0.12.0-incub...

Posted by pferrel <gi...@git.apache.org>.
Github user pferrel commented on the issue:

    https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6
  
    Upgrading HDFS may also come with a conversion process if data is stored there. Not sure. 


---

[GitHub] incubator-predictionio-template-java-ecom-recommender issue #6: 0.12.0-incub...

Posted by pferrel <gi...@git.apache.org>.
Github user pferrel commented on the issue:

    https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6
  
    Also the build.sbt locks people into the latest versions of Spark, etc. So this template will no longer work with services installed with pio-0.11.0 including the Scala version. Existing users should be warned about this--do not upgrade pio unless you are willing to upgrade scala, and other services. In the case of ES it means wiping the meta store, which in turn means they must `pio export` before upgrading and `pio import` into new apps to get metadata re-created in ES5.  


---

[GitHub] incubator-predictionio-template-java-ecom-recommender issue #6: 0.12.0-incub...

Posted by pferrel <gi...@git.apache.org>.
Github user pferrel commented on the issue:

    https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6
  
    Making templates easier for users doing upgrades is extremely important IMO.
    
    Getting them working with 0.12.0 is first priority and I for one appreciate @shimamoto and @takezoe taking this on. But we need to make this better for the future. 


---

[GitHub] incubator-predictionio-template-java-ecom-recommender issue #6: 0.12.0-incub...

Posted by pferrel <gi...@git.apache.org>.
Github user pferrel commented on the issue:

    https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6
  
    the PR is fine, but this can be solved partially with the current templates. For instance why not support both the previous defaults (those used in 0.11.0) AND the latest defaults. This could be by leaving 2 build.sbts in the project, one for 0.10.0, one for 0.11.0. Better yet @dszeto says we can now build with sbt, which means we can have the optional libs in a single build.sbt controlled by CLI. 


---

[GitHub] incubator-predictionio-template-java-ecom-recommender issue #6: 0.12.0-incub...

Posted by shimamoto <gi...@git.apache.org>.
Github user shimamoto commented on the issue:

    https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6
  
    I have checked it works.
    @takezoe Can you review this PR?


---

[GitHub] incubator-predictionio-template-java-ecom-recommender issue #6: 0.12.0-incub...

Posted by pferrel <gi...@git.apache.org>.
Github user pferrel commented on the issue:

    https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6
  
    @shimamoto @takezoe this does not support all the pio build options and so will not work if pio is built in a different way from this template. We need to document this at very least and solve the pio vs template mismatched options more fundamentally maybe by creating a sample template build that supports all `make-distribution` options. But I see problems with doing this too so not sure how to solve it.


---