You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by no...@apache.org on 2020/12/29 12:37:11 UTC

[buildstream] 01/07: element.py: Promote __update_source_state to API private

This is an automated email from the ASF dual-hosted git repository.

not-in-ldap pushed a commit to branch shared/split_out_update_state
in repository https://gitbox.apache.org/repos/asf/buildstream.git

commit 75fe5507f5a5eaac36b26113abaa25ee8ff3ff41
Author: Jonathan Maw <jo...@codethink.co.uk>
AuthorDate: Wed Apr 17 16:18:53 2019 +0100

    element.py: Promote __update_source_state to API private
    
    There are now times when we want to call _update_source_state outside of
    Element.
---
 buildstream/element.py | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/buildstream/element.py b/buildstream/element.py
index 95081b9..5f4215e 100644
--- a/buildstream/element.py
+++ b/buildstream/element.py
@@ -1166,7 +1166,7 @@ class Element(Plugin):
         context = self._get_context()
 
         # Compute and determine consistency of sources
-        self.__update_source_state()
+        self._update_source_state()
 
         if self._get_consistency() == Consistency.INCONSISTENT:
             # Tracking may still be pending
@@ -2283,15 +2283,11 @@ class Element(Plugin):
         else:
             return True
 
-    #############################################################
-    #                   Private Local Methods                   #
-    #############################################################
-
-    # __update_source_state()
+    # _update_source_state()
     #
     # Updates source consistency state
     #
-    def __update_source_state(self):
+    def _update_source_state(self):
 
         # Cannot resolve source state until tracked
         if self.__tracking_scheduled:
@@ -2316,6 +2312,11 @@ class Element(Plugin):
                 source._update_state()
                 self.__consistency = min(self.__consistency, source._get_consistency())
 
+
+    #############################################################
+    #                   Private Local Methods                   #
+    #############################################################
+
     # __can_build_incrementally()
     #
     # Check if the element can be built incrementally, this