You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by kxepal <gi...@git.apache.org> on 2015/01/06 03:28:27 UTC
[GitHub] couchdb-couch pull request: 2534 db security respect authed users
GitHub user kxepal opened a pull request:
https://github.com/apache/couchdb-couch/pull/29
2534 db security respect authed users
This does two things:
- Fixes the way how user name is searched in list. lists:member/2 made in BIF, faster and doesn't causes redundant list copy;
- Fixes readers vs members terminology in code;
- Fixes COUCHDB-2534, throwing forbidden error if user is authenticated, but is not a database member.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kxepal/couchdb-couch 2534-db-security-respect-authed-users
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-couch/pull/29.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #29
----
commit d3c7d13346f3f5af679970bb80374d7c8f0a5b67
Author: Alexander Shorin <kx...@apache.org>
Date: 2015-01-06T02:12:39Z
Use lists:member/2 to check if user name is in list
commit 3300fca3a35c0d0075a79af6a5662ff9537bc5e3
Author: Alexander Shorin <kx...@apache.org>
Date: 2015-01-06T02:16:05Z
Throw forbidden error if user is authenticated on db membership check
COUCHDB-2534
commit 7134d7ebd6d9d9c6586f37df9ef9aa2b6891b38a
Author: Alexander Shorin <kx...@apache.org>
Date: 2015-01-06T02:19:32Z
Normalize terminology readers vs members
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 2534 db security respect authed users
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/29#issuecomment-69361998
Applied refactoring onto this PR. Also throw correct error for check_is_admin/1 when end user is authed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 2534 db security respect authed users
Posted by davisp <gi...@git.apache.org>.
Github user davisp commented on the pull request:
https://github.com/apache/couchdb-couch/pull/29#issuecomment-85280210
+1 after squashing the refactor commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 2534 db security respect authed users
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-couch/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 2534 db security respect authed users
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/29#issuecomment-68825578
Made a bit refactor of `checks_is_*` functions in separate branch to get rid deep case nesting and unify member/admin check logic: https://github.com/kxepal/couchdb-couch/commit/24df7cf9
If it's ok, will push it right after this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-couch pull request: 2534 db security respect authed users
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-couch/pull/29#issuecomment-68818706
On second thought, using ordsets might be better choice for all these names/roles checks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---