You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by "Joshua Bronson (JIRA)" <ji...@apache.org> on 2009/10/29 17:32:59 UTC
[jira] Created: (COUCHDB-547) add "compact view" button to futon
add "compact view" button to futon
----------------------------------
Key: COUCHDB-547
URL: https://issues.apache.org/jira/browse/COUCHDB-547
Project: CouchDB
Issue Type: New Feature
Components: HTTP Interface
Reporter: Joshua Bronson
Priority: Minor
Attachments: compactviewbutton.diff
The attached patch, created via "git diff --binary 1b2855063bc6ddccb6a7003a7243930678673ba7... > compactviewbutton.diff" from within a clone of git://github.com/jab/couchdb.git (see http://github.com/jab/couchdb), adds a "compact view" button to futon when browsing a view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-547) add "compact view" button to futon
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771751#action_12771751 ]
Paul Joseph Davis commented on COUCHDB-547:
-------------------------------------------
Joshua,
Patch looks mostly good. Couple things:
1. When you're not on a design doc the disabled "Compact View" button shouldn't be visible.
2. The compact view should probably be to the right of "Delete Database" to make sure that DB operations are grouped. Plus it'll help as "Compact View" isn't always visible, thus lessening confusion if buttons moved.
3. The dialog box text needs a bit of work:
"Compacting a view removes deleted documents and previous revisions. It is an irreversible operation and may take a while to complete for large views."
Should read something like:
"View compaction will affect all views in this design document. This operation may take some time to complete. Your views will still operate normally during compaction."
Or some such. Deleting and removing and revisions and irreversible are all things that people shouldn't be forced to consider when doing view compaction because none of those are remotely related.
Other than those minor tweaks, it looks good to me.
> add "compact view" button to futon
> ----------------------------------
>
> Key: COUCHDB-547
> URL: https://issues.apache.org/jira/browse/COUCHDB-547
> Project: CouchDB
> Issue Type: New Feature
> Components: HTTP Interface
> Reporter: Joshua Bronson
> Priority: Minor
> Attachments: compactviewbutton.diff
>
>
> The attached patch, created via "git diff --binary 1b2855063bc6ddccb6a7003a7243930678673ba7... > compactviewbutton.diff" from within a clone of git://github.com/jab/couchdb.git (see http://github.com/jab/couchdb), adds a "compact view" button to futon when browsing a view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-547) add "compact view" button to futon
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771757#action_12771757 ]
Paul Joseph Davis commented on COUCHDB-547:
-------------------------------------------
I'd rather see hidden out as it seems like it'd have more visual weight appearing only for the view stuff so that people aren't wondering how to enable it.
The patch seems to work out. The binary bit threw me for a second till I realized the file name. I didn't notice a difference because the grayed out style made the entire icon disappear.
Yep yep, go ahead and make those fixes and we'll get this committed. Feel free to flip a quarter on grayed vs hidden.
> add "compact view" button to futon
> ----------------------------------
>
> Key: COUCHDB-547
> URL: https://issues.apache.org/jira/browse/COUCHDB-547
> Project: CouchDB
> Issue Type: New Feature
> Components: HTTP Interface
> Reporter: Joshua Bronson
> Priority: Minor
> Attachments: compactviewbutton.diff
>
>
> The attached patch, created via "git diff --binary 1b2855063bc6ddccb6a7003a7243930678673ba7... > compactviewbutton.diff" from within a clone of git://github.com/jab/couchdb.git (see http://github.com/jab/couchdb), adds a "compact view" button to futon when browsing a view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-547) add "compact view" button to futon
Posted by "Joshua Bronson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771990#action_12771990 ]
Joshua Bronson commented on COUCHDB-547:
----------------------------------------
Thought about it some more and I think it should be hidden too. I should know better by now than to trust my 2AM logic. Attaching a new patch which hides rather than grays out, changes instances of ?0.9.0 to ?0.10.1 (on the theory that trunk should stay ahead of the latest release yeah?), and with the other fixes above.
A truly complete patch would include a test, but I have to leave that for the future for now.
Let me know how it looks.
> add "compact view" button to futon
> ----------------------------------
>
> Key: COUCHDB-547
> URL: https://issues.apache.org/jira/browse/COUCHDB-547
> Project: CouchDB
> Issue Type: New Feature
> Components: HTTP Interface
> Reporter: Joshua Bronson
> Priority: Minor
> Attachments: compactviewbutton.diff
>
>
> The attached patch, created via "git diff --binary 1b2855063bc6ddccb6a7003a7243930678673ba7... > compactviewbutton.diff" from within a clone of git://github.com/jab/couchdb.git (see http://github.com/jab/couchdb), adds a "compact view" button to futon when browsing a view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-547) add "compact view" button to futon
Posted by "Joshua Bronson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771815#action_12771815 ]
Joshua Bronson commented on COUCHDB-547:
----------------------------------------
> I didn't notice a difference because the grayed out style made the entire icon disappear.
Yikes, that's no good. Are you able to see the fourth icon from the top when you view http://github.com/jab/couchdb/blob/master/share/www/image/compact.png? If not, maybe it's your monitor's brightness/contrast settings; if so, maybe your browser was using a cached copy of that image? This would explain your not seeing the icon, as the old version of the image was only 96 pixels high, and the new button.disabled style sets a vertical background-position of -94px. I'll append a ?0.10.0 to the url for that background-image in the css file to make sure this doesn't happen.
> go ahead and make those fixes and we'll get this committed.
I pushed the fixes to http://github.com/jab/couchdb. I'll have a new patched attached to this ticket tomorrow.
> Feel free to flip a quarter on grayed vs hidden.
I'm inclined to leave it grayed out, and not just because it was extra work! (It was fun anyway:) My theory is that graying it out actually does communicate its state better than not showing it at all. Maybe your not seeing the icon properly screwed up that communication. And also your eyes and mousing hand like it better when widgets stay where they are; sometimes having them disappear violates the principle of least astonishment[1]. I can get the opinion of one of the designers in my office tomorrow. Or maybe just give it another look once I submit the new patch and you can see the grayed out icon, and let me know if you still prefer it hidden!
[1] http://en.wikipedia.org/wiki/Principle_of_least_astonishment :)
> add "compact view" button to futon
> ----------------------------------
>
> Key: COUCHDB-547
> URL: https://issues.apache.org/jira/browse/COUCHDB-547
> Project: CouchDB
> Issue Type: New Feature
> Components: HTTP Interface
> Reporter: Joshua Bronson
> Priority: Minor
> Attachments: compactviewbutton.diff
>
>
> The attached patch, created via "git diff --binary 1b2855063bc6ddccb6a7003a7243930678673ba7... > compactviewbutton.diff" from within a clone of git://github.com/jab/couchdb.git (see http://github.com/jab/couchdb), adds a "compact view" button to futon when browsing a view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-547) add "compact view" button to futon
Posted by "Joshua Bronson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771753#action_12771753 ]
Joshua Bronson commented on COUCHDB-547:
----------------------------------------
> Patch looks mostly good
glad to hear it!
> 1. When you're not on a design doc the disabled "Compact View" button shouldn't be visible.
Oh, I brought it up in the channel today and kocolosk said it should be grayed out rather than hidden, so I added the "button.disabled" stuff you'll notice in layout.css and database.html. Also, I added a fourth sprite to the bottom of compact.png so the button would look disabled; did this make it through when you applied the attached patch? I noticed it says "GIT binary patch" in the attached where it gives the hunk(?) for compact.png, wonder whether that means you have to use git-apply to get this part of the patch to work?
> 2. The compact view should probably be to the right of "Delete Database" to make sure that DB operations are grouped. Plus it'll help as "Compact View" isn't always visible, thus lessening confusion if buttons moved.
> 3. The dialog box text needs a bit of work:
<snip/>
Both 2 and 3 sound good to me. Want me to make the changes and resubmit the patch?
> add "compact view" button to futon
> ----------------------------------
>
> Key: COUCHDB-547
> URL: https://issues.apache.org/jira/browse/COUCHDB-547
> Project: CouchDB
> Issue Type: New Feature
> Components: HTTP Interface
> Reporter: Joshua Bronson
> Priority: Minor
> Attachments: compactviewbutton.diff
>
>
> The attached patch, created via "git diff --binary 1b2855063bc6ddccb6a7003a7243930678673ba7... > compactviewbutton.diff" from within a clone of git://github.com/jab/couchdb.git (see http://github.com/jab/couchdb), adds a "compact view" button to futon when browsing a view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-547) add "compact view" button to futon
Posted by "Joshua Bronson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772614#action_12772614 ]
Joshua Bronson commented on COUCHDB-547:
----------------------------------------
> Thanks for the patch. Applied as of r831485.
Sweet, and my pleasure.
> I ixnayed all the s/0.9.0/0.10.1/ changes as they're quite orthogonal to the patch. Also, trunk is referred to as a minor revision after the current release, ie, as soon as 0.10.x was branched, trunk effectively became 0.11.x. Feel free to attach just the version updates to a new ticket and I'll apply them. I'm not gonna do this myself because I'm still convinced that we should be doing this differently, I just don't know how exactly. I'm starting to lean towards writing a script that we'll run after we branch a version that will go through and update version numbers. That'd allow us to update them for the revision versions as well. A project for another day anyway.
Cool, I split off a new issue for this at https://issues.apache.org/jira/browse/COUCHDB-557.
> I did let the linking of the database in though because its generally useful and I was too lazy to split up the patch for a one line diff. Knowing Git has subfile commits just makes me sad when using SVN.
=)
> add "compact view" button to futon
> ----------------------------------
>
> Key: COUCHDB-547
> URL: https://issues.apache.org/jira/browse/COUCHDB-547
> Project: CouchDB
> Issue Type: New Feature
> Components: HTTP Interface
> Reporter: Joshua Bronson
> Assignee: Paul Joseph Davis
> Priority: Minor
> Fix For: 0.11
>
> Attachments: compactviewbutton.diff, compactviewbutton.take2.diff
>
>
> The attached patch, created via "git diff --binary 1b2855063bc6ddccb6a7003a7243930678673ba7... > compactviewbutton.diff" from within a clone of git://github.com/jab/couchdb.git (see http://github.com/jab/couchdb), adds a "compact view" button to futon when browsing a view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-547) add "compact view" button to futon
Posted by "Adam Kocoloski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771759#action_12771759 ]
Adam Kocoloski commented on COUCHDB-547:
----------------------------------------
Hiding "Compact View" is fine by me, too. Sorry if I made you go through extra work, Joshua.
> add "compact view" button to futon
> ----------------------------------
>
> Key: COUCHDB-547
> URL: https://issues.apache.org/jira/browse/COUCHDB-547
> Project: CouchDB
> Issue Type: New Feature
> Components: HTTP Interface
> Reporter: Joshua Bronson
> Priority: Minor
> Attachments: compactviewbutton.diff
>
>
> The attached patch, created via "git diff --binary 1b2855063bc6ddccb6a7003a7243930678673ba7... > compactviewbutton.diff" from within a clone of git://github.com/jab/couchdb.git (see http://github.com/jab/couchdb), adds a "compact view" button to futon when browsing a view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (COUCHDB-547) add "compact view" button to futon
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Joseph Davis resolved COUCHDB-547.
---------------------------------------
Resolution: Fixed
Fix Version/s: 0.11
Assignee: Paul Joseph Davis
Joshua,
Thanks for the patch. Applied as of r831485.
I ixnayed all the s/0.9.0/0.10.1/ changes as they're quite orthogonal to the patch. Also, trunk is referred to as a minor revision after the current release, ie, as soon as 0.10.x was branched, trunk effectively became 0.11.x. Feel free to attach just the version updates to a new ticket and I'll apply them. I'm not gonna do this myself because I'm still convinced that we should be doing this differently, I just don't know how exactly. I'm starting to lean towards writing a script that we'll run after we branch a version that will go through and update version numbers. That'd allow us to update them for the revision versions as well. A project for another day anyway.
I did let the linking of the database in though because its generally useful and I was too lazy to split up the patch for a one line diff. Knowing Git has subfile commits just makes me sad when using SVN.
> add "compact view" button to futon
> ----------------------------------
>
> Key: COUCHDB-547
> URL: https://issues.apache.org/jira/browse/COUCHDB-547
> Project: CouchDB
> Issue Type: New Feature
> Components: HTTP Interface
> Reporter: Joshua Bronson
> Assignee: Paul Joseph Davis
> Priority: Minor
> Fix For: 0.11
>
> Attachments: compactviewbutton.diff, compactviewbutton.take2.diff
>
>
> The attached patch, created via "git diff --binary 1b2855063bc6ddccb6a7003a7243930678673ba7... > compactviewbutton.diff" from within a clone of git://github.com/jab/couchdb.git (see http://github.com/jab/couchdb), adds a "compact view" button to futon when browsing a view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-547) add "compact view" button to futon
Posted by "Joshua Bronson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771539#action_12771539 ]
Joshua Bronson commented on COUCHDB-547:
----------------------------------------
Also, I noticed that throughout futon the <script...> tags still point to .js files with a query string of ?0.9.0. I didn't change any of these in my patch, but I take it these should all have been changed to ?0.10.0 with the 0.10 release?
> add "compact view" button to futon
> ----------------------------------
>
> Key: COUCHDB-547
> URL: https://issues.apache.org/jira/browse/COUCHDB-547
> Project: CouchDB
> Issue Type: New Feature
> Components: HTTP Interface
> Reporter: Joshua Bronson
> Priority: Minor
> Attachments: compactviewbutton.diff
>
>
> The attached patch, created via "git diff --binary 1b2855063bc6ddccb6a7003a7243930678673ba7... > compactviewbutton.diff" from within a clone of git://github.com/jab/couchdb.git (see http://github.com/jab/couchdb), adds a "compact view" button to futon when browsing a view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-547) add "compact view" button to futon
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771828#action_12771828 ]
Paul Joseph Davis commented on COUCHDB-547:
-------------------------------------------
Thinking idly before bed, I'm inclined to think that having it grayed out on a page that isn't a view seems more astonishing that hidden. To me its the same argument as not having a grayed out "Delete Database" button when viewing the list of databases page. The intent of the button doesn't have a valid meaning in that context. Plus, I can't think of any other button that does the grayed out status, so having a special status indication for a single button also seems more astonishing than hiding it.
> add "compact view" button to futon
> ----------------------------------
>
> Key: COUCHDB-547
> URL: https://issues.apache.org/jira/browse/COUCHDB-547
> Project: CouchDB
> Issue Type: New Feature
> Components: HTTP Interface
> Reporter: Joshua Bronson
> Priority: Minor
> Attachments: compactviewbutton.diff
>
>
> The attached patch, created via "git diff --binary 1b2855063bc6ddccb6a7003a7243930678673ba7... > compactviewbutton.diff" from within a clone of git://github.com/jab/couchdb.git (see http://github.com/jab/couchdb), adds a "compact view" button to futon when browsing a view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-547) add "compact view" button to futon
Posted by "Joshua Bronson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joshua Bronson updated COUCHDB-547:
-----------------------------------
Attachment: compactviewbutton.diff
> add "compact view" button to futon
> ----------------------------------
>
> Key: COUCHDB-547
> URL: https://issues.apache.org/jira/browse/COUCHDB-547
> Project: CouchDB
> Issue Type: New Feature
> Components: HTTP Interface
> Reporter: Joshua Bronson
> Priority: Minor
> Attachments: compactviewbutton.diff
>
>
> The attached patch, created via "git diff --binary 1b2855063bc6ddccb6a7003a7243930678673ba7... > compactviewbutton.diff" from within a clone of git://github.com/jab/couchdb.git (see http://github.com/jab/couchdb), adds a "compact view" button to futon when browsing a view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (COUCHDB-547) add "compact view" button to futon
Posted by "Joshua Bronson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Joshua Bronson updated COUCHDB-547:
-----------------------------------
Attachment: compactviewbutton.take2.diff
> add "compact view" button to futon
> ----------------------------------
>
> Key: COUCHDB-547
> URL: https://issues.apache.org/jira/browse/COUCHDB-547
> Project: CouchDB
> Issue Type: New Feature
> Components: HTTP Interface
> Reporter: Joshua Bronson
> Priority: Minor
> Attachments: compactviewbutton.diff, compactviewbutton.take2.diff
>
>
> The attached patch, created via "git diff --binary 1b2855063bc6ddccb6a7003a7243930678673ba7... > compactviewbutton.diff" from within a clone of git://github.com/jab/couchdb.git (see http://github.com/jab/couchdb), adds a "compact view" button to futon when browsing a view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (COUCHDB-547) add "compact view" button to futon
Posted by "Paul Joseph Davis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/COUCHDB-547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771560#action_12771560 ]
Paul Joseph Davis commented on COUCHDB-547:
-------------------------------------------
The 'correct' thing would probably be to have that version number inserted by the build system which is easy enough in theory except that it has the effect of requiring two files, and then hacking on Futon gets a bit weird. Perhaps we could do that as part of an install hook or something to have them replaced inline as part of a `make install`?
Its bugged me for a bit but I can't think of a decent solution. And just s/0.9/0.10/ seemed to not address the underlying issue.
Does anyone have a decent solution for this in projects outside of Futon?
> add "compact view" button to futon
> ----------------------------------
>
> Key: COUCHDB-547
> URL: https://issues.apache.org/jira/browse/COUCHDB-547
> Project: CouchDB
> Issue Type: New Feature
> Components: HTTP Interface
> Reporter: Joshua Bronson
> Priority: Minor
> Attachments: compactviewbutton.diff
>
>
> The attached patch, created via "git diff --binary 1b2855063bc6ddccb6a7003a7243930678673ba7... > compactviewbutton.diff" from within a clone of git://github.com/jab/couchdb.git (see http://github.com/jab/couchdb), adds a "compact view" button to futon when browsing a view.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.