You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/03 11:36:41 UTC

[jira] [Commented] (TINKERPOP-1663) Validate a maximum for the number of parameters passed to Gremlin Server

    [ https://issues.apache.org/jira/browse/TINKERPOP-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953329#comment-15953329 ] 

ASF GitHub Bot commented on TINKERPOP-1663:
-------------------------------------------

GitHub user spmallette opened a pull request:

    https://github.com/apache/tinkerpop/pull/591

    TINKERPOP-1663 Validation for maximum number of parameters on a request

    https://issues.apache.org/jira/browse/TINKERPOP-1663
    
    Provides a configuration option to validate the number of parameters that gremlin server will accept on a request for script evaluation.
    
    Ran integration tests for gremlin-server and console.
    
    vOTE +1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1663

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/591.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #591
    
----
commit a4c652ae3c071c15c5a57524a797707f5ea318a4
Author: Stephen Mallette <sp...@genoprime.com>
Date:   2017-04-03T11:04:42Z

    TINKERPOP-1663 Validation for maximum number of parameters on a request
    
    The default is set to 16 and there is a configuration option to allow it to be changed.

----


> Validate a maximum for the number of parameters passed to Gremlin Server
> ------------------------------------------------------------------------
>
>                 Key: TINKERPOP-1663
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-1663
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: server
>    Affects Versions: 3.2.4
>            Reporter: stephen mallette
>            Assignee: stephen mallette
>
> Given that tests have shown that scripts with very large number of parameters take a longer amount of time to compile than scripts with smaller numbers of parameters, having some control over the number of allowed parameters might help prevent users from falling into an anti-pattern. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)