You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/09/26 11:44:39 UTC

[PR] Deduplicate Oracle ALTER PROFILE and Doris BITOR parser cases [shardingsphere]

terrymanu opened a new pull request, #39969:
URL: https://github.com/apache/shardingsphere/pull/39969

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deduplicate Oracle ALTER PROFILE and Doris BITOR parser cases [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39969:
URL: https://github.com/apache/shardingsphere/pull/39969#issuecomment-5845992647

   ### Result
   **Review Result: Mergeable**
   
   The four-file local candidate contains the three intended fixture changes and no unrelated hunks.
   
   ### Evidence
   - The removed Oracle `time1` case had the same SQL and expected assertion as the retained case.
   - Renaming `time2` changed only its ID; its SQL and expected assertion are unchanged.
   - The removed Doris case had the same SQL and expected parser tree as the retained `select_bitor` case.
   - Oracle parser IT: 1,968 passed. Doris parser IT: 1,388 passed. `git diff --check` passed.
   
   ### Coverage
   Standalone local candidate against `HEAD`; reviewed all four XML files, their references, and the Oracle and Doris test paths. Parser implementation and other dialects are unchanged. This is a code-scope result; CI was not reviewed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Deduplicate Oracle ALTER PROFILE and Doris BITOR parser cases [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39969:
URL: https://github.com/apache/shardingsphere/pull/39969


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org